TrueCloudLab/neoneo-go
6
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity
neoneo-go/pkg/core
History
Roman Khimov 65016e8070 core: fix data race in notary test 
I don't think it's possible with regular service functioning, but it happens
during testing because of pointer reuse:

WARNING: DATA RACE
Read at 0x00c003a0e3f0 by goroutine 114:
  github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).verifyIncompleteWitnesses()
      /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:441 +0x1dc
  github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).OnNewRequest()
      /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:188 +0x205
  github.com/nspcc-dev/neo-go/pkg/core.TestNotary.func11()
      /home/runner/work/neo-go/neo-go/pkg/core/notary_test.go:347 +0x612
  github.com/nspcc-dev/neo-go/pkg/core.TestNotary()
      /home/runner/work/neo-go/neo-go/pkg/core/notary_test.go:443 +0xe33
  testing.tRunner()
      /opt/hostedtoolcache/go/1.16.10/x64/src/testing/testing.go:1193 +0x202

Previous write at 0x00c003a0e3f0 by goroutine 104:
  github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).finalize()
      /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:338 +0x50a
  github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).PostPersist()
      /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:314 +0x297
  github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).Run()
      /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:169 +0x4a7
2021-11-15 17:33:02 +03:00
..
block network: remove priority queue from block queue 2021-11-01 11:49:01 +03:00
blockchainer rpc: refactor calculatenetworkfee handler 2021-10-25 19:07:25 +03:00
chaindump block: drop Network from the Header 2021-03-26 13:45:18 +03:00
dao core: split (*MemCachedStore) Seek and SeekAsync methods 2021-10-21 10:05:12 +03:00
fee vm: add PACKMAP/PACKSTRUCT, extend UNPACK 2021-11-12 17:19:59 +03:00
interop Merge pull request #2251 from nspcc-dev/rules-witness-scope 2021-11-12 18:25:39 +03:00
mempool mempool: reword ErrConflict message, fix #2197 2021-09-28 09:57:42 +03:00
mempoolevent core: move mempool.Event to a separate package 2021-06-01 12:24:28 +03:00
mpt core: handle empty MPT batch properly 2021-10-27 18:44:39 +03:00
native core: refactor callers of MemCachedStore.Seek 2021-10-21 10:05:12 +03:00
state core: refactor callers of MemCachedStore.Seek 2021-10-21 10:05:12 +03:00
stateroot rpc: refactor calculatenetworkfee handler 2021-10-25 19:07:25 +03:00
statesync rpc: implement findstates RPC handler 2021-10-13 11:41:05 +03:00
storage storage: drop RedisDB, close #2130 2021-10-27 17:32:25 +03:00
test_data core/block: add Nonce field to header 2021-07-15 15:58:49 +03:00
transaction transaction: add new Rules witness scope 2021-11-12 15:29:28 +03:00
bench_test.go rpc: refactor calculatenetworkfee handler 2021-10-25 19:07:25 +03:00
blockchain.go rpc: refactor calculatenetworkfee handler 2021-10-25 19:07:25 +03:00
blockchain_test.go subscriptions: add container hash to notification event 2021-09-24 17:42:02 +03:00
doc.go core: add Blockchain event subscription mechanism 2020-05-25 00:27:39 +03:00
helper_test.go core/test: allow to determine system fee automatically 2021-11-11 11:15:15 +03:00
interop_system.go core: add finalizer functions to interop context 2021-10-21 10:05:12 +03:00
interop_system_test.go transaction: add new Rules witness scope 2021-11-12 15:29:28 +03:00
interops.go interop: implement System.Runtime.GetRandom 2021-07-15 16:00:01 +03:00
interops_test.go core: remove conflicting transactions wrt MaxTraceableBlocks 2021-08-18 13:31:47 +03:00
native_contract_test.go core: remove conflicting transactions wrt MaxTraceableBlocks 2021-08-18 13:31:47 +03:00
native_designate_test.go core/test: get rid of empty tx scripts 2021-07-15 15:58:49 +03:00
native_gas_test.go native: drop Refuel method from GAS 2021-08-05 10:27:13 +03:00
native_ledger_test.go core/block: add Nonce field to header 2021-07-15 15:58:49 +03:00
native_management_test.go core: maintain a set of NEP17-compliant contracts 2021-07-28 13:22:53 +03:00
native_neo_test.go core: move NNS test out of core 2021-11-11 11:15:15 +03:00
native_notary_test.go config: make MaxValidUntilBlockIncrement configurable 2021-05-17 13:43:03 +03:00
native_oracle_test.go core/test: get rid of empty tx scripts 2021-07-15 15:58:49 +03:00
native_policy_test.go native/policy: disallow blocking native contracts 2021-09-03 11:11:06 +03:00
notary_test.go core: fix data race in notary test 2021-11-15 17:33:02 +03:00
oracle_test.go *: simplify some error messages 2021-07-23 10:08:09 +03:00
prometheus.go stateroot: move state-root related logic to core/stateroot 2021-03-09 13:48:29 +03:00
stateroot_test.go *: make tests use TempDir(), fix #1319 2021-08-26 17:29:40 +03:00
statesync_test.go core: check MPT node is not requested twice by StateSync module 2021-10-12 14:08:56 +03:00
util.go core/block: add Nonce field to header 2021-07-15 15:58:49 +03:00
util_test.go core/block: add Nonce field to header 2021-07-15 15:58:49 +03:00