TrueCloudLab/policy-engine
20
0
Fork 11
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Extend LocalOverrideStorage interface with target listing methods #43

New issue
Closed
opened 2024-01-19 13:42:42 +00:00 by aarifullin · 0 comments
aarifullin commented 2024-01-19 13:42:42 +00:00
Member
Copy link

LocalOverrideStorage interface lacks a method that allows to list targets for which local overrides are set.

It is suggested to introduce a method like that:

ListOverrideDefinedTargets(name chain.Name) ([]Target, error)

After this method will be introduced, it is required to implement it in frostfs-node's chain base

[LocalOverrideStorage](https://git.frostfs.info/TrueCloudLab/policy-engine/src/branch/master/pkg/engine/interface.go#L17) interface lacks a method that allows to list targets for which local overrides are set. It is suggested to introduce a method like that: ```go ListOverrideDefinedTargets(name chain.Name) ([]Target, error) ``` After this method will be introduced, it is required to implement it in [frostfs-node's chain base](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/ape/chainbase/boltdb.go)
acid-ant self-assigned this 2024-01-23 08:43:40 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feat/list_by_iterator
feature/3_policy-contract-interface
feature/support-iam_to_native_converter
init
No results found.
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
acid-ant
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#43
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?