TrueCloudLab/policy-engine
21
0
Fork 11
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

engine: Extend with target listing method #47

Merged
acid-ant merged 1 commit from acid-ant/policy-engine:feature/43-list-targets into master 2024-01-29 08:04:14 +00:00
Conversation 1 Commits 1 Files changed 3 +16
acid-ant commented 2024-01-26 14:28:52 +00:00
Member
Copy link

Close #43

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #43 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2024-01-26 14:29:11 +00:00
acid-ant requested review from storage-core-developers 2024-01-26 14:29:12 +00:00
acid-ant requested review from storage-services-committers 2024-01-26 14:29:13 +00:00
acid-ant requested review from storage-services-developers 2024-01-26 14:29:13 +00:00
dstepanov-yadro approved these changes 2024-01-26 14:57:39 +00:00
dstepanov-yadro left a comment
Member
Copy link

Looks correct, but unnecessary variables ok and i could be removed.

Looks correct, but unnecessary variables `ok` and `i` could be removed.
👍 1
dkirillov approved these changes 2024-01-26 14:58:55 +00:00
alexvanin approved these changes 2024-01-26 15:07:21 +00:00
acid-ant force-pushed feature/43-list-targets from e2b6a67b53 to 6f61bf54a1 2024-01-29 06:30:06 +00:00 Compare
acid-ant commented 2024-01-29 06:30:25 +00:00
Author
Member
Copy link

Looks correct, but unnecessary variables ok and i could be removed.

Updated.

> Looks correct, but unnecessary variables `ok` and `i` could be removed. Updated.
acid-ant force-pushed feature/43-list-targets from 6f61bf54a1 to 8d21ab2d99 2024-01-29 06:41:55 +00:00 Compare
dkirillov approved these changes 2024-01-29 07:46:40 +00:00
acid-ant merged commit 8d21ab2d99 into master 2024-01-29 08:04:14 +00:00
acid-ant deleted branch feature/43-list-targets 2024-01-29 08:04:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
alexvanin
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#47
No description provided.
Delete branch "acid-ant/policy-engine:feature/43-list-targets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?