TrueCloudLab/policy-engine
21
0
Fork 11
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

[#63] iam: Support tag keys #63

Merged
fyrchik merged 1 commit from dkirillov/policy-engine:feature/iam-tags into master 2024-04-05 11:22:59 +00:00
Conversation 0 Commits 1 Files changed 3 +76 -2
dkirillov commented 2024-04-04 11:19:18 +00:00
Member
Copy link

Support:

  • aws:PrincipalTag
  • aws:ResourceTag
  • aws:Request

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Support: * aws:PrincipalTag * aws:ResourceTag * aws:Request Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-04-04 11:19:18 +00:00
dkirillov changed title from [#XX] iam: Support tag keys to [#63] iam: Support tag keys 2024-04-04 11:19:30 +00:00
dkirillov force-pushed feature/iam-tags from 8baf3b7dc3 to eb296dd757 2024-04-04 11:20:04 +00:00 Compare
dkirillov requested review from storage-core-committers 2024-04-04 11:20:45 +00:00
dkirillov requested review from storage-core-developers 2024-04-04 11:20:52 +00:00
dkirillov requested review from storage-services-committers 2024-04-04 11:20:58 +00:00
fyrchik approved these changes 2024-04-04 11:27:24 +00:00
iam/converter.go Outdated
@ -66,0 +66,4 @@
const (
condKeyAWSPrincipalARN = "aws:PrincipalArn"
condKeyAWSPrincipalTagPrefix = "aws:PrincipalTag/"
userClaimTagPrefix = "tag-"
fyrchik commented 2024-04-04 11:26:13 +00:00
Owner
Copy link

To be clear, is this tag- something present in AWS/S3 spec or our addition?

To be clear, is this `tag-` something present in AWS/S3 spec or our addition?
dkirillov commented 2024-04-04 11:52:04 +00:00
Author
Member
Copy link

Our addition, to distinguish tags in user claims.

Our addition, to distinguish tags in user claims.
fyrchik marked this conversation as resolved
iam/converter.go Outdated
@ -188,1 +193,4 @@
func transformKey(key string) string {
switch {
case strings.HasPrefix(key, condKeyAWSPrincipalTagPrefix):
fyrchik commented 2024-04-04 11:27:17 +00:00
Owner
Copy link

What about using https://pkg.go.dev/strings#CutPrefix? (it combines HasPrefix and TrimPrefix)
Or do we expect this switch to grow?

What about using https://pkg.go.dev/strings#CutPrefix? (it combines `HasPrefix` and `TrimPrefix`) Or do we expect this switch to grow?
dkirillov commented 2024-04-04 11:54:44 +00:00
Author
Member
Copy link

In the future I expect this switch to grow, but for now I'll change to using CutPrefix

In the future I expect this switch to grow, but for now I'll change to using `CutPrefix`
fyrchik marked this conversation as resolved
dkirillov force-pushed feature/iam-tags from eb296dd757 to 1cf6417ed2 2024-04-04 11:57:03 +00:00 Compare
mbiryukova reviewed 2024-04-04 15:40:30 +00:00
iam/converter_test.go Outdated
@ -1503,0 +1547,4 @@
err := json.Unmarshal([]byte(policy), &p)
require.NoError(t, err)
s3Chain, err := ConvertToNativeChain(p, newMockUserResolver(nil, nil, ""))
mbiryukova commented 2024-04-04 15:40:30 +00:00
Member
Copy link

Should be ConvertToS3Chain?

Should be `ConvertToS3Chain`?
👀 1
dkirillov commented 2024-04-05 06:26:22 +00:00
Author
Member
Copy link

Oh, sure

Oh, sure
mbiryukova marked this conversation as resolved
dkirillov force-pushed feature/iam-tags from 1cf6417ed2 to 67e4595a91 2024-04-05 06:36:15 +00:00 Compare
mbiryukova approved these changes 2024-04-05 07:00:42 +00:00
aarifullin approved these changes 2024-04-05 09:09:54 +00:00
acid-ant approved these changes 2024-04-05 09:46:08 +00:00
fyrchik merged commit 67e4595a91 into master 2024-04-05 11:22:59 +00:00
fyrchik referenced this pull request from a commit 2024-04-05 11:23:01 +00:00
[#63] iam: Support tag keys
dkirillov deleted branch feature/iam-tags 2024-04-08 06:20:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
mbiryukova
aarifullin
acid-ant
TrueCloudLab/storage-services-committers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#63
No description provided.
Delete branch "dkirillov/policy-engine:feature/iam-tags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?