TrueCloudLab/policy-engine
18
0
Fork 10
generated from TrueCloudLab/basic
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

[#67] chain: Support IPAddress conditions #67

Merged
dkirillov merged 1 commit from dkirillov/policy-engine:feature/ip_conditions into master 2024-04-15 12:52:42 +00:00
Conversation 0 Commits 1 Files changed 4 +167 -24
dkirillov commented 2024-04-10 15:12:15 +00:00
Member
Copy link

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-04-10 15:12:15 +00:00
dkirillov changed title from [#XX] chain: Support IPAddress conditions to [#67] chain: Support IPAddress conditions 2024-04-10 15:12:24 +00:00
dkirillov force-pushed feature/ip_conditions from fe3864d3c6 to dadc43e5e7 2024-04-10 15:12:40 +00:00 Compare
dkirillov requested review from storage-core-committers 2024-04-10 15:13:29 +00:00
dkirillov requested review from storage-core-developers 2024-04-10 15:13:32 +00:00
pogpp approved these changes 2024-04-10 17:10:42 +00:00
fyrchik reviewed 2024-04-11 07:33:55 +00:00
iam/converter.go Outdated
@ -303,2 +306,4 @@
}
func ipConvertFunction(val string) (string, error) {
parsedIP, _, err := net.ParseCIDR(val)
fyrchik commented 2024-04-11 07:33:55 +00:00
Owner
Copy link

Consider using netip package, it should be more optimized (ParseCIDR is netip.ParsePrefix, other functions also should be present there).

Consider using `netip` package, it should be more optimized (`ParseCIDR` is `netip.ParsePrefix`, other functions also should be present there).
👍 1
dkirillov force-pushed feature/ip_conditions from dadc43e5e7 to 55e98f4a3a 2024-04-11 07:50:26 +00:00 Compare
dkirillov force-pushed feature/ip_conditions from 55e98f4a3a to c146ab165e 2024-04-12 07:32:34 +00:00 Compare
dstepanov-yadro approved these changes 2024-04-15 12:07:57 +00:00
alexvanin approved these changes 2024-04-15 12:50:58 +00:00
dkirillov merged commit ff5d05ac92 into master 2024-04-15 12:52:42 +00:00
dkirillov deleted branch feature/ip_conditions 2024-04-15 12:52:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
dstepanov-yadro
alexvanin
TrueCloudLab/storage-core-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#67
No description provided.
Delete branch "dkirillov/policy-engine:feature/ip_conditions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?