TrueCloudLab/policy-engine
18
0
Fork 10
generated from TrueCloudLab/basic
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

[#87] iam: Support s3:PatchObject action #87

Merged
fyrchik merged 1 commit from mbiryukova/policy-engine:feature/s3_patch into master 2024-08-22 10:41:53 +00:00
Conversation 0 Commits 1 Files changed 3 +3
mbiryukova commented 2024-08-20 13:32:36 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-08-20 13:32:36 +00:00
mbiryukova added 1 commit 2024-08-20 13:32:39 +00:00
[#xx] iam: Support s3:PatchObject action
Some checks failed
DCO action / DCO (pull_request) Failing after 1m3s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m6s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m8s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m17s
Details
Tests and linters / Lint (pull_request) Successful in 1m55s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m54s
Details
40877f89ed 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova force-pushed feature/s3_patch from 40877f89ed to dc23ab0bfa 2024-08-20 13:33:17 +00:00 Compare
mbiryukova changed title from [#xx] iam: Support s3:PatchObject action to [#87] iam: Support s3:PatchObject action 2024-08-20 13:33:40 +00:00
mbiryukova requested review from storage-core-committers 2024-08-20 13:37:51 +00:00
mbiryukova requested review from storage-core-developers 2024-08-20 13:37:54 +00:00
mbiryukova requested review from storage-services-committers 2024-08-20 13:37:57 +00:00
mbiryukova requested review from storage-services-developers 2024-08-20 13:38:00 +00:00
alexvanin reviewed 2024-08-20 14:22:27 +00:00
iam/converter_native.go Outdated
@ -60,6 +60,7 @@ var actionToNativeOpMap = map[string][]string{
s3ActionPutObjectTagging: {native.MethodGetContainer, native.MethodHeadObject, native.MethodGetObject, native.MethodPutObject},
s3ActionPutObjectVersionACL: {native.MethodGetContainer, native.MethodGetContainerEACL, native.MethodSetContainerEACL, native.MethodGetObject, native.MethodHeadObject},
s3ActionPutObjectVersionTagging: {native.MethodGetContainer, native.MethodHeadObject, native.MethodGetObject, native.MethodPutObject},
s3ActionPatchObject: {native.MethodGetContainer, native.MethodGetObject, native.MethodHeadObject, native.MethodPatchObject},
alexvanin commented 2024-08-20 14:22:27 +00:00
Owner
Copy link

native.MethodGetObject and native.MethodHeadObject are for multi-part uploads or is it required for regular objects as well?

`native.MethodGetObject` and `native.MethodHeadObject` are for multi-part uploads or is it required for regular objects as well?
fyrchik commented 2024-08-20 14:27:18 +00:00
Owner
Copy link

@aarifullin do we need Put too?

@aarifullin do we need `Put` too?
mbiryukova commented 2024-08-20 15:02:12 +00:00
Author
Member
Copy link

Get, as I understand while testing, is needed for retrieving bucket settings (and for multi-part uploads too), Head for all objects

Get, as I understand while testing, is needed for retrieving bucket settings (and for multi-part uploads too), Head for all objects
dkirillov commented 2024-08-21 06:33:48 +00:00
Member
Copy link

Actually we have to add Put. We update object version in tree service which is required to have allowed Put

Actually we have to add `Put`. We update object version in tree service which is required to have allowed `Put`
dkirillov commented 2024-08-21 12:44:42 +00:00
Member
Copy link

Can we use the same oprerations as for s3:PutObject with additional (native:Patch)? So I also suggest add MethodRangeObject

Can we use the same oprerations as for `s3:PutObject` with additional (native:Patch)? So I also suggest add `MethodRangeObject`
mbiryukova commented 2024-08-21 13:34:36 +00:00
Author
Member
Copy link

Added

Added
mbiryukova force-pushed feature/s3_patch from dc23ab0bfa to 2284c87b47 2024-08-21 07:30:18 +00:00 Compare
acid-ant approved these changes 2024-08-21 08:28:34 +00:00
mbiryukova force-pushed feature/s3_patch from 2284c87b47 to 472013f4eb 2024-08-21 13:21:01 +00:00 Compare
alexvanin approved these changes 2024-08-21 13:44:30 +00:00
dkirillov approved these changes 2024-08-22 06:54:36 +00:00
fyrchik merged commit a3bc3099bd into master 2024-08-22 10:41:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
alexvanin
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#87
No description provided.
Delete branch "mbiryukova/policy-engine:feature/s3_patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?