generated from TrueCloudLab/basic
Introduce ChainID type and several methods for interface #13
No reviewers
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/policy-engine#13
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "aarifullin/policy-engine:feature/chain_interface"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
CachedChainStorage
interface. It must be taken in count that the interface will be splitted and refactored soonf81fb8b5b3
to83314f185c
83314f185c
to59648010b6
@ -13,7 +13,13 @@ type Engine interface {
IsAllowed(name Name, namespace string, r Request) (Status, bool)
}
// ChainID is the ID of chain that is used for local overrides.
In contract we have
ingress:somethingelse
structure?So how about using string as ID?
It can be generated by node.
Alright, I don't mind
59648010b6
tof955e31c13
@ -16,1 +17,4 @@
type ChainID string
type Chain struct {
// ID is applicable only for local overrides.
Actually, it is apllicable for contracts too: we may store multiple chains there.
I meant ChainID is rather useful to manipulate local overrides because we need to pass it in
frostfs-cli
if we want to remove/get the chain info.I haven't thought about the idea how it is can be used for the contract invocation. Anyway, let's keep the field and remove the comment
@aarifullin Is my understanding correct: this PR is needed to do something sane in the frostfs-node and this PR will be later superceeded by #7 ?
That's absolutely right
f955e31c13
to76372aac04