TrueCloudLab/policy-engine
17
0
Fork 10
generated from TrueCloudLab/basic
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Make Deny the highest priority #29

Merged
fyrchik merged 1 commit from dstepanov-yadro/policy-engine:feat/allow_to_process_in_order into master 2024-09-04 19:51:23 +00:00
Conversation 1 Commits 1 Files changed 3 +84
dstepanov-yadro commented 2023-12-08 09:39:10 +00:00
Member
Copy link

Closes #21

After this PR need to change eACL -> APE converter: TrueCloudLab/frostfs-node#852

Closes #21 After this PR need to change eACL -> APE converter: https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/852
dstepanov-yadro added 1 commit 2023-12-08 09:39:11 +00:00
[#21] router: Make Deny the highest priority
All checks were successful
DCO action / DCO (pull_request) Successful in 1m5s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m15s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m34s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m31s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m32s
Details
Tests and linters / Lint (pull_request) Successful in 2m22s
Details
1375e8f7fd 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro changed title from WIP: Make Deny the highest priority to Make Deny the highest priority 2023-12-08 11:11:12 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-12-08 11:11:17 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-12-08 11:11:17 +00:00
dstepanov-yadro force-pushed feat/allow_to_process_in_order from 89ecc7b36e to 780bf5cb0f 2023-12-08 11:19:34 +00:00 Compare
aarifullin approved these changes 2023-12-08 15:08:56 +00:00
aarifullin approved these changes 2023-12-08 15:09:00 +00:00
dstepanov-yadro force-pushed feat/allow_to_process_in_order from 780bf5cb0f to 9604e580f7 2023-12-11 07:09:49 +00:00 Compare
dstepanov-yadro reviewed 2023-12-11 07:13:32 +00:00
pkg/chain/chain.go Outdated
@ -15,0 +17,4 @@
const (
// MatchTypeDenyPriority rejects the request if any `Deny` is specified.
MatchTypeDenyPriority MatchType = 0
dstepanov-yadro commented 2023-12-11 07:13:19 +00:00
Author
Member
Copy link

I don't like iota.

I don't like `iota`.
fyrchik requested review from alexvanin 2023-12-11 07:33:18 +00:00
fyrchik requested review from dkirillov 2023-12-11 07:33:18 +00:00
dkirillov approved these changes 2023-12-11 07:52:40 +00:00
dkirillov left a comment
Member
Copy link

Can we change test in iam package to

diff --git a/iam/policy_test.go b/iam/policy_test.go
index 046035d..c397f33 100644
--- a/iam/policy_test.go
+++ b/iam/policy_test.go
@@ -478,6 +478,7 @@ func TestProcessDenyFirst(t *testing.T) {
 
        identityNativePolicy, err := ConvertToNativeChain(identityPolicy, mockResolver)
        require.NoError(t, err)
+       identityNativePolicy.MatchType = chain.MatchTypeFirstMatch
 
        resourceNativePolicy, err := ConvertToNativeChain(resourcePolicy, mockResolver)
        require.NoError(t, err)

?

Can we change test in `iam` package to ```diff diff --git a/iam/policy_test.go b/iam/policy_test.go index 046035d..c397f33 100644 --- a/iam/policy_test.go +++ b/iam/policy_test.go @@ -478,6 +478,7 @@ func TestProcessDenyFirst(t *testing.T) { identityNativePolicy, err := ConvertToNativeChain(identityPolicy, mockResolver) require.NoError(t, err) + identityNativePolicy.MatchType = chain.MatchTypeFirstMatch resourceNativePolicy, err := ConvertToNativeChain(resourcePolicy, mockResolver) require.NoError(t, err) ``` ?
dstepanov-yadro force-pushed feat/allow_to_process_in_order from 9604e580f7 to 8c673ee4f4 2023-12-11 08:03:13 +00:00 Compare
dstepanov-yadro commented 2023-12-11 08:03:20 +00:00
Author
Member
Copy link

Can we change test in iam package to

diff --git a/iam/policy_test.go b/iam/policy_test.go
index 046035d..c397f33 100644
--- a/iam/policy_test.go
+++ b/iam/policy_test.go
@@ -478,6 +478,7 @@ func TestProcessDenyFirst(t *testing.T) {
 
        identityNativePolicy, err := ConvertToNativeChain(identityPolicy, mockResolver)
        require.NoError(t, err)
+       identityNativePolicy.MatchType = chain.MatchTypeFirstMatch
 
        resourceNativePolicy, err := ConvertToNativeChain(resourcePolicy, mockResolver)
        require.NoError(t, err)

?

Done

> Can we change test in `iam` package to > ```diff > diff --git a/iam/policy_test.go b/iam/policy_test.go > index 046035d..c397f33 100644 > --- a/iam/policy_test.go > +++ b/iam/policy_test.go > @@ -478,6 +478,7 @@ func TestProcessDenyFirst(t *testing.T) { > > identityNativePolicy, err := ConvertToNativeChain(identityPolicy, mockResolver) > require.NoError(t, err) > + identityNativePolicy.MatchType = chain.MatchTypeFirstMatch > > resourceNativePolicy, err := ConvertToNativeChain(resourcePolicy, mockResolver) > require.NoError(t, err) > > ``` > ? Done
dkirillov approved these changes 2023-12-11 08:08:21 +00:00
fyrchik merged commit 8c673ee4f4 into master 2023-12-11 12:36:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
alexvanin
dkirillov
TrueCloudLab/storage-core-committers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#29
No description provided.
Delete branch "dstepanov-yadro/policy-engine:feat/allow_to_process_in_order"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?