TrueCloudLab
/
policy-engine
generated from TrueCloudLab/basic
20
0
Fork 9
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

WIP: morph: Fix container resource name transformer #31

Closed
aarifullin wants to merge 1 commits from aarifullin/policy-engine:fix/transform_container_target into master
pull from: aarifullin/policy-engine:fix/transform_container_target
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files Changed 2
aarifullin commented 2023-12-12 14:31:04 +00:00
Collaborator

Signed-off-by: Airat Arifullin aarifullin@yadro.com

Signed-off-by: Airat Arifullin <aarifullin@yadro.com>
aarifullin added the
bug
 label 2023-12-12 14:31:04 +00:00
aarifullin force-pushed fix/transform_container_target from cbbd0b2e26 to 74dade0e43 2023-12-12 14:31:43 +00:00 Compare
aarifullin requested review from storage-services-committers 2023-12-12 14:32:25 +00:00
aarifullin requested review from storage-services-developers 2023-12-12 14:32:29 +00:00
aarifullin requested review from storage-core-committers 2023-12-12 14:32:49 +00:00
dstepanov-yadro approved these changes 2023-12-12 14:38:30 +00:00
aarifullin requested review from storage-core-developers 2023-12-12 14:50:36 +00:00
aarifullin force-pushed fix/transform_container_target from 74dade0e43 to a7bb0e6b8b 2023-12-12 14:52:07 +00:00 Compare
aarifullin requested review from dstepanov-yadro 2023-12-12 14:53:03 +00:00
fyrchik reviewed 2023-12-12 14:56:00 +00:00
pkg/morph/policy/policy_contract_storage.go
@ -50,3 +51,3 @@
// Container name can be too long and, thus, cannot be
// used as a key name for policy-contract storage.
name = base58.FastBase58Encoding([]byte(target.Name))
encoded := sha256.Sum224([]byte(target.Name))
fyrchik commented 2023-12-12 14:55:57 +00:00
Owner

What about raw []byte slice? it's 32 bytes. Well, it is hash, so taking a prefix is almost equivalent to this Sum224.

What about raw `[]byte` slice? it's 32 bytes. Well, it _is_ hash, so taking a prefix is almost equivalent to this `Sum224`.
fyrchik commented 2023-12-12 14:56:21 +00:00
Owner

And why 224?

And why `224`?
elebedeva approved these changes 2023-12-12 15:04:30 +00:00
aarifullin changed title from morph: Fix container resource name transformer to WIP: morph: Fix container resource name transformer 2023-12-12 15:24:52 +00:00
aarifullin closed this pull request 2023-12-18 09:38:55 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 52s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m18s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m28s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m30s
Details
Tests and linters / Lint (pull_request) Successful in 2m30s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
elebedeva
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#31
There is no content yet.
Delete Branch "aarifullin/policy-engine:fix/transform_container_target"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?