TrueCloudLab
/
policy-engine
generated from TrueCloudLab/basic
20
0
Fork 9
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

engine: Fix target considering order #49

Merged
fyrchik merged 1 commits from aarifullin/policy-engine:fix/router_target_prior into master 2024-02-06 13:20:43 +00:00
Conversation 2 Commits 1 Files Changed 1
aarifullin commented 2024-02-06 08:46:29 +00:00
Collaborator
  • Namespace target rules should be considered first
* Namespace target rules should be considered first
aarifullin added the
bug
 label 2024-02-06 08:46:29 +00:00
aarifullin added 1 commit 2024-02-06 08:46:31 +00:00
DCO action / DCO (pull_request) Successful in 59s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m10s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m20s Details
Tests and linters / Staticcheck (pull_request) Successful in 1m31s Details
Tests and linters / Tests with -race (pull_request) Successful in 1m38s Details
Tests and linters / Lint (pull_request) Successful in 2m16s Details
b30245dcff [#XX] engine: Fix target considering order 
* Namespace target rules should be considered first

Signed-off-by: Airat Arifullin <aarifullin@yadro.com>
aarifullin requested review from storage-core-committers 2024-02-06 08:47:42 +00:00
aarifullin requested review from storage-core-developers 2024-02-06 08:47:50 +00:00
aarifullin requested review from storage-services-committers 2024-02-06 08:48:05 +00:00
aarifullin requested review from storage-services-developers 2024-02-06 08:48:14 +00:00
dstepanov-yadro approved these changes 2024-02-06 09:45:18 +00:00
acid-ant approved these changes 2024-02-06 09:54:31 +00:00
acid-ant commented 2024-02-06 09:54:48 +00:00
Collaborator

Please reword commit message.

Please reword commit message.
fyrchik approved these changes 2024-02-06 09:56:30 +00:00
fyrchik requested changes 2024-02-06 11:10:55 +00:00
fyrchik left a comment
Owner

Commit message, rebase on master, please

Commit message, rebase on master, please
aarifullin force-pushed fix/router_target_prior from b30245dcff to 8354a074c4 2024-02-06 11:12:54 +00:00 Compare
aarifullin commented 2024-02-06 11:13:03 +00:00
Poster
Collaborator

Commit message, rebase on master, please

Sure

> Commit message, rebase on master, please Sure
aarifullin requested review from fyrchik 2024-02-06 11:13:23 +00:00
acid-ant approved these changes 2024-02-06 11:38:41 +00:00
fyrchik merged commit 8354a074c4 into master 2024-02-06 13:20:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#49
There is no content yet.
Delete Branch "aarifullin/policy-engine:fix/router_target_prior"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?