TrueCloudLab/policy-engine
18
0
Fork 10
generated from TrueCloudLab/basic
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

[#4] Add IAM policy unmarshaler #5

Merged
dkirillov merged 1 commit from dkirillov/policy-engine:feature/iam_policy_unmarshaler into master 2024-09-04 19:51:23 +00:00
Conversation 0 Commits 1 Files changed 1 +25 -35
dkirillov commented 2023-10-19 13:16:03 +00:00
Member
Copy link

close #4

Currently numeric condition type are not supported

close #4 Currently numeric condition type are not supported
dkirillov self-assigned this 2023-10-19 13:16:03 +00:00
dkirillov added 1 commit 2023-10-19 13:16:04 +00:00
dkirillov changed title from WIP: [#XX] Add IAM policy unmarshaler to WIP: [#XX] Add IAM policy unmarshaler 2023-10-20 07:53:00 +00:00
dkirillov changed target branch from init to master 2023-10-20 07:53:01 +00:00
dkirillov force-pushed feature/iam_policy_unmarshaler from 0933aa7ce6 to 31a308ea61 2023-10-23 12:44:46 +00:00 Compare
dkirillov changed title from WIP: [#XX] Add IAM policy unmarshaler to WIP: [#4] Add IAM policy unmarshaler 2023-10-23 12:45:11 +00:00
dkirillov changed title from WIP: [#4] Add IAM policy unmarshaler to [#4] Add IAM policy unmarshaler 2023-10-23 12:56:59 +00:00
dkirillov requested review from storage-core-committers 2023-10-23 12:57:06 +00:00
dkirillov requested review from storage-core-developers 2023-10-23 12:57:07 +00:00
dkirillov requested review from storage-services-committers 2023-10-23 12:57:08 +00:00
dkirillov requested review from storage-services-developers 2023-10-23 12:57:08 +00:00
dstepanov-yadro reviewed 2023-10-23 14:41:19 +00:00
iam/policy.go
@ -0,0 +45,4 @@
DenyEffect Effect = "Deny"
)
func (s *Statements) UnmarshalJSON(data []byte) error {
dstepanov-yadro commented 2023-10-23 14:41:13 +00:00
Member
Copy link

Not a bug: what about using https://github.com/mailru/easyjson ?

Not a bug: what about using https://github.com/mailru/easyjson ?
dkirillov commented 2023-10-24 14:14:10 +00:00
Author
Member
Copy link

We cannot use solely easyjson because we have to parse both

{
	"Statement": {
		"Principal": "*"
    }
}

and

{
	"Statement": {
		"Principal": {
            "AWS":[
				"arn:aws:iam::111122223333:user/JohnDoe"
			],
           "FrostFS": "031a6c6fbbdf02ca351745fa86b9ba5a9452d785ac4f7fc2b7548ca2a46c4fcf4a",
    }
}

So we need custom UnmarshalJSON anyway.

Error in tests when using easyjson:

=== RUN   TestUnmarshalIAMPolicy/simple_fields
    policy_test.go:51: 
        	Error Trace:	/home/denis/github/tcl/policy-engine/iam/policy_test.go:51
        	Error:      	Received unexpected error:
        	            	parse error: expected [ near offset 66 of 'Statement'
        	Test:       	TestUnmarshalIAMPolicy/simple_fields
--- FAIL: TestUnmarshalIAMPolicy/simple_fields (0.00s)
We cannot use solely easyjson because we have to parse both ```json { "Statement": { "Principal": "*" } } ``` and ```json { "Statement": { "Principal": { "AWS":[ "arn:aws:iam::111122223333:user/JohnDoe" ], "FrostFS": "031a6c6fbbdf02ca351745fa86b9ba5a9452d785ac4f7fc2b7548ca2a46c4fcf4a", } } ``` So we need custom `UnmarshalJSON` anyway. Error in tests when using easyjson: ``` === RUN TestUnmarshalIAMPolicy/simple_fields policy_test.go:51: Error Trace: /home/denis/github/tcl/policy-engine/iam/policy_test.go:51 Error: Received unexpected error: parse error: expected [ near offset 66 of 'Statement' Test: TestUnmarshalIAMPolicy/simple_fields --- FAIL: TestUnmarshalIAMPolicy/simple_fields (0.00s) ```
dstepanov-yadro commented 2023-10-24 14:27:09 +00:00
Member
Copy link

Clear, thx!

Clear, thx!
dstepanov-yadro marked this conversation as resolved
dstepanov-yadro approved these changes 2023-10-24 14:27:34 +00:00
fyrchik approved these changes 2023-10-24 15:30:26 +00:00
iam/policy.go
@ -0,0 +7,4 @@
type (
// Policy grammar https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html
// Currently 'NotPrincipal', 'NotAction' and 'NotResource' are not supported (so cannot be unmarshalled).
fyrchik commented 2023-10-24 15:29:00 +00:00
Owner
Copy link

Do we have a task for this?

Do we have a task for this?
dkirillov commented 2023-10-27 07:36:58 +00:00
Author
Member
Copy link

#11

https://git.frostfs.info/TrueCloudLab/policy-engine/issues/11
iam/policy.go
@ -0,0 +87,4 @@
continue
}
list, ok := val.([]interface{})
fyrchik commented 2023-10-24 15:29:53 +00:00
Owner
Copy link

Let's use any?

Let's use `any`?
dkirillov commented 2023-10-27 07:37:24 +00:00
Author
Member
Copy link

Fix later

Fix later
dkirillov merged commit 31a308ea61 into master 2023-10-27 07:37:42 +00:00
dkirillov deleted branch feature/iam_policy_unmarshaler 2023-10-27 07:37:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#5
No description provided.
Delete branch "dkirillov/policy-engine:feature/iam_policy_unmarshaler"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?