TrueCloudLab/policy-engine
18
0
Fork 10
generated from TrueCloudLab/basic
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Revise MorphRuleChainStorage interface and introduce ContractStorageReader #54

Merged
fyrchik merged 2 commits from aarifullin/policy-engine:feat/contract_storage_reader into master 2024-03-01 08:05:26 +00:00
Conversation 4 Commits 2 Files changed 4 +69 -7
aarifullin commented 2024-02-26 15:36:06 +00:00
Member
Copy link
  • Split MorphRuleChainStorage interface by moving read-only methods to a separate interface MorphRuleChainStorageReader.
  • Implement MorphRuleChainStorageReader interface to make possible to read from Policy contract without wallets.
* Split MorphRuleChainStorage interface by moving read-only methods to a separate interface MorphRuleChainStorageReader. * Implement MorphRuleChainStorageReader interface to make possible to read from Policy contract without wallets.
aarifullin changed title from WIP: Revise MorphRuleChainStorage interface and introduce ContractStorageReader to Revise MorphRuleChainStorage interface and introduce ContractStorageReader 2024-02-26 15:52:02 +00:00
aarifullin force-pushed feat/contract_storage_reader from 822691ec50 to 33585fa7ca 2024-02-26 15:52:59 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-02-26 15:53:11 +00:00
aarifullin requested review from storage-core-developers 2024-02-26 15:53:11 +00:00
aarifullin requested review from storage-services-committers 2024-02-26 15:53:15 +00:00
aarifullin requested review from storage-services-developers 2024-02-26 15:53:16 +00:00
aarifullin changed title from Revise MorphRuleChainStorage interface and introduce ContractStorageReader to WIP: Revise MorphRuleChainStorage interface and introduce ContractStorageReader 2024-02-26 15:54:56 +00:00
fyrchik commented 2024-02-26 16:13:48 +00:00
Owner
Copy link

How about just implementing unwrappers here?
So we will use auto-generated bindings in node, and call unwrap.ListOfChains on the result.
This reduces the number of wrappers we have.

EDIT: nvm, wrappers are still useful for the types we accept.

How about just implementing unwrappers here? So we will use auto-generated bindings in node, and call `unwrap.ListOfChains` on the result. This reduces the number of wrappers we have. EDIT: nvm, wrappers are still useful for the types we accept.
dkirillov commented 2024-02-27 06:28:29 +00:00
Member
Copy link

Should we use new MorphRuleChainStorageReader in router and maybe in Engine then?
It seems they use read only methods

Should we use new `MorphRuleChainStorageReader` in [router](https://git.frostfs.info/aarifullin/policy-engine/src/commit/33585fa7caf7c02b2639d2abd1d4fd804e4662f0/pkg/engine/chain_router.go) and maybe in `Engine` then? It seems they use read only methods
👍 1
fyrchik commented 2024-02-28 16:39:35 +00:00
Owner
Copy link

Why is it WIP?

Why is it WIP?
aarifullin changed title from WIP: Revise MorphRuleChainStorage interface and introduce ContractStorageReader to Revise MorphRuleChainStorage interface and introduce ContractStorageReader 2024-02-29 10:32:28 +00:00
aarifullin commented 2024-02-29 10:55:18 +00:00
Author
Member
Copy link

Should we use new MorphRuleChainStorageReader in router and maybe in Engine then?
It seems they use read only methods

maybe in Engine

Engine should be able to change its state by adding/removing rules. So, only router should use ...Reader

> Should we use new `MorphRuleChainStorageReader` in [router](https://git.frostfs.info/aarifullin/policy-engine/src/commit/33585fa7caf7c02b2639d2abd1d4fd804e4662f0/pkg/engine/chain_router.go) and maybe in `Engine` then? > It seems they use read only methods > maybe in `Engine` `Engine` should be able to change its state by adding/removing rules. So, only router should use `...Reader`
aarifullin force-pushed feat/contract_storage_reader from 33585fa7ca to 4154899cff 2024-02-29 10:57:33 +00:00 Compare
dkirillov approved these changes 2024-03-01 07:25:18 +00:00
fyrchik approved these changes 2024-03-01 08:05:03 +00:00
fyrchik merged commit cf1f091e26 into master 2024-03-01 08:05:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#54
No description provided.
Delete branch "aarifullin/policy-engine:feat/contract_storage_reader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?