Allow to remove all chains by target #56

Merged
acid-ant merged 1 commit from acid-ant/policy-engine:feature/remove-all-chains into master 2024-09-04 19:51:23 +00:00
Member

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from dkirillov 2024-03-07 11:14:36 +00:00
acid-ant requested review from storage-core-committers 2024-03-07 11:14:36 +00:00
acid-ant requested review from storage-core-developers 2024-03-07 11:14:38 +00:00
acid-ant force-pushed feature/remove-all-chains from 0c873171a2 to 8e3aeb1797 2024-03-07 12:50:41 +00:00 Compare
fyrchik approved these changes 2024-03-07 13:39:02 +00:00
dkirillov approved these changes 2024-03-07 13:40:49 +00:00
@ -44,1 +44,4 @@
func (s *inmemoryMorphRuleChainStorage) RemoveMorphRuleChainsByTarget(name chain.Name, target engine.Target) (_ util.Uint256, _ uint32, err error) {
switch target.Type {
case engine.Namespace:
Member

Maybe we can use case engine.Namespace, engine.Container: (in other methods should be updated then though)?

Maybe we can use `case engine.Namespace, engine.Container:` (in other methods should be updated then though)?
Author
Member

Right, looks like now we can use one storage for both.

Right, looks like now we can use one storage for both.
Author
Member

Updated. Please review.

Updated. Please review.
Member

Rebase, please

Rebase, please
Author
Member

Thanks, done.

Thanks, done.
dkirillov marked this conversation as resolved
acid-ant force-pushed feature/remove-all-chains from 8e3aeb1797 to 91e5c84e04 2024-03-07 14:09:58 +00:00 Compare
acid-ant force-pushed feature/remove-all-chains from 91e5c84e04 to d828c33e94 2024-03-07 15:02:00 +00:00 Compare
acid-ant changed title from Allow to remove all chains by target to WIP: Allow to remove all chains by target 2024-03-07 15:05:23 +00:00
acid-ant force-pushed feature/remove-all-chains from d828c33e94 to 2ec958cbfd 2024-03-07 15:11:26 +00:00 Compare
acid-ant changed title from WIP: Allow to remove all chains by target to Allow to remove all chains by target 2024-03-07 15:13:47 +00:00
Author
Member

Missed few places when implementing a review comment, now it is ready.

Missed few places when implementing a review comment, now it is ready.
aarifullin approved these changes 2024-03-07 15:59:44 +00:00
acid-ant merged commit 2ec958cbfd into master 2024-03-07 16:01:10 +00:00
acid-ant referenced this pull request from a commit 2024-03-07 16:01:12 +00:00
Sign in to join this conversation.
No description provided.