TrueCloudLab/policy-engine
20
0
Fork 11
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Allow to remove all chains by target #56

Merged
acid-ant merged 1 commit from acid-ant/policy-engine:feature/remove-all-chains into master 2024-09-04 19:51:23 +00:00
Conversation 1 Commits 1 Files changed 6 +145 -20
acid-ant commented 2024-03-07 11:14:16 +00:00
Member
Copy link

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from dkirillov 2024-03-07 11:14:36 +00:00
acid-ant requested review from storage-core-committers 2024-03-07 11:14:36 +00:00
acid-ant requested review from storage-core-developers 2024-03-07 11:14:38 +00:00
acid-ant force-pushed feature/remove-all-chains from 0c873171a2 to 8e3aeb1797 2024-03-07 12:50:41 +00:00 Compare
fyrchik approved these changes 2024-03-07 13:39:02 +00:00
dkirillov approved these changes 2024-03-07 13:40:49 +00:00
pkg/engine/inmemory/morph_storage.go Outdated
@ -44,1 +44,4 @@
func (s *inmemoryMorphRuleChainStorage) RemoveMorphRuleChainsByTarget(name chain.Name, target engine.Target) (_ util.Uint256, _ uint32, err error) {
switch target.Type {
case engine.Namespace:
dkirillov commented 2024-03-07 13:40:38 +00:00
Member
Copy link

Maybe we can use case engine.Namespace, engine.Container: (in other methods should be updated then though)?

Maybe we can use `case engine.Namespace, engine.Container:` (in other methods should be updated then though)?
acid-ant commented 2024-03-07 14:09:11 +00:00
Author
Member
Copy link

Right, looks like now we can use one storage for both.

Right, looks like now we can use one storage for both.
acid-ant commented 2024-03-07 14:11:14 +00:00
Author
Member
Copy link

Updated. Please review.

Updated. Please review.
dkirillov commented 2024-03-07 14:13:59 +00:00
Member
Copy link

Rebase, please

Rebase, please
acid-ant commented 2024-03-07 15:02:13 +00:00
Author
Member
Copy link

Thanks, done.

Thanks, done.
dkirillov marked this conversation as resolved
acid-ant force-pushed feature/remove-all-chains from 8e3aeb1797 to 91e5c84e04 2024-03-07 14:09:58 +00:00 Compare
acid-ant force-pushed feature/remove-all-chains from 91e5c84e04 to d828c33e94 2024-03-07 15:02:00 +00:00 Compare
acid-ant changed title from Allow to remove all chains by target to WIP: Allow to remove all chains by target 2024-03-07 15:05:23 +00:00
acid-ant force-pushed feature/remove-all-chains from d828c33e94 to 2ec958cbfd 2024-03-07 15:11:26 +00:00 Compare
acid-ant changed title from WIP: Allow to remove all chains by target to Allow to remove all chains by target 2024-03-07 15:13:47 +00:00
acid-ant commented 2024-03-07 15:15:49 +00:00
Author
Member
Copy link

Missed few places when implementing a review comment, now it is ready.

Missed few places when implementing a review comment, now it is ready.
aarifullin approved these changes 2024-03-07 15:59:44 +00:00
acid-ant merged commit 2ec958cbfd into master 2024-03-07 16:01:10 +00:00
acid-ant referenced this pull request from a commit 2024-03-07 16:01:12 +00:00
[#56] Fix pre-commit issue
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dkirillov
aarifullin
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#56
No description provided.
Delete branch "acid-ant/policy-engine:feature/remove-all-chains"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?