TrueCloudLab/policy-engine
21
0
Fork 12
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

schema: Introduce xheader property #84

Merged
aarifullin merged 1 commit from aarifullin/policy-engine:feat/xheader into master 2024-07-12 12:04:42 +00:00
Conversation 0 Commits 1 Files changed 1 +2
aarifullin commented 2024-07-11 16:20:56 +00:00
Member
Copy link

This prefix for for an xheader name is mandatory as a property is taken for request property and a client has to be unable to accidently/intentionally override request properites (yes, this still can be checked with the service before sending to IsAllowed but the proper way is to use this prefix to avoid collisions)

This prefix for for an xheader name is mandatory as a property is taken for request property and a client has to be unable to accidently/intentionally override request properites (yes, this still can be checked with the service before sending to `IsAllowed` but the proper way is to use this prefix to avoid collisions)
aarifullin added 1 commit 2024-07-11 16:21:06 +00:00
[#XX] schema: Introduce xheader property
Some checks failed
DCO action / DCO (pull_request) Failing after 1m34s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m33s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m47s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m44s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m58s
Details
Tests and linters / Lint (pull_request) Successful in 3m4s
Details
c91cf4befd 
Signed-off-by: Airat Arifullin <aarifullin@yadro.com>
aarifullin requested review from storage-core-committers 2024-07-11 16:21:44 +00:00
aarifullin force-pushed feat/xheader from c91cf4befd to 37c90c1c84 2024-07-11 16:21:45 +00:00 Compare
aarifullin requested review from storage-core-developers 2024-07-11 16:22:08 +00:00
aarifullin requested review from storage-services-committers 2024-07-11 16:22:22 +00:00
aarifullin requested review from storage-services-developers 2024-07-11 16:22:32 +00:00
dstepanov-yadro approved these changes 2024-07-12 06:07:16 +00:00
dkirillov approved these changes 2024-07-12 06:19:14 +00:00
acid-ant approved these changes 2024-07-12 07:03:22 +00:00
aarifullin force-pushed feat/xheader from 37c90c1c84 to 2628f61849 2024-07-12 08:14:18 +00:00 Compare
aarifullin requested review from dstepanov-yadro 2024-07-12 08:14:33 +00:00
aarifullin requested review from acid-ant 2024-07-12 08:14:36 +00:00
aarifullin requested review from dkirillov 2024-07-12 08:14:37 +00:00
acid-ant approved these changes 2024-07-12 08:51:23 +00:00
aarifullin merged commit 2628f61849 into master 2024-07-12 12:04:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
dkirillov
acid-ant
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#84
No description provided.
Delete branch "aarifullin/policy-engine:feat/xheader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?