TrueCloudLab/policy-engine
21
0
Fork 12
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

[#87] iam: Support s3:PatchObject action #87

Merged
fyrchik merged 1 commit from mbiryukova/policy-engine:feature/s3_patch into master 2024-08-22 10:41:53 +00:00
Conversation 0 Commits 1 Files changed 3 +3
3 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 472013f4eb - Show all commits

1
iam/converter.go
View file

@ -63,6 +63,7 @@ const (
s3ActionPutObjectTagging = "s3:PutObjectTagging"
s3ActionPutObjectVersionACL = "s3:PutObjectVersionAcl"
s3ActionPutObjectVersionTagging = "s3:PutObjectVersionTagging"
s3ActionPatchObject = "s3:PatchObject"
)
const (

1
iam/converter_native.go
View file

@ -60,6 +60,7 @@ var actionToNativeOpMap = map[string][]string{
s3ActionPutObjectTagging: {native.MethodGetContainer, native.MethodHeadObject, native.MethodGetObject, native.MethodPutObject},
s3ActionPutObjectVersionACL: {native.MethodGetContainer, native.MethodGetContainerEACL, native.MethodSetContainerEACL, native.MethodGetObject, native.MethodHeadObject},
s3ActionPutObjectVersionTagging: {native.MethodGetContainer, native.MethodHeadObject, native.MethodGetObject, native.MethodPutObject},
s3ActionPatchObject: {native.MethodGetContainer, native.MethodGetObject, native.MethodHeadObject, native.MethodPatchObject, native.MethodPutObject, native.MethodRangeObject},
alexvanin commented 2024-08-20 14:22:27 +00:00
Outdated
Review
Copy link

native.MethodGetObject and native.MethodHeadObject are for multi-part uploads or is it required for regular objects as well?

`native.MethodGetObject` and `native.MethodHeadObject` are for multi-part uploads or is it required for regular objects as well?
fyrchik commented 2024-08-20 14:27:18 +00:00
Outdated
Review
Copy link

@aarifullin do we need Put too?

@aarifullin do we need `Put` too?
mbiryukova commented 2024-08-20 15:02:12 +00:00
Outdated
Review
Copy link

Get, as I understand while testing, is needed for retrieving bucket settings (and for multi-part uploads too), Head for all objects

Get, as I understand while testing, is needed for retrieving bucket settings (and for multi-part uploads too), Head for all objects
dkirillov commented 2024-08-21 06:33:48 +00:00
Outdated
Review
Copy link

Actually we have to add Put. We update object version in tree service which is required to have allowed Put

Actually we have to add `Put`. We update object version in tree service which is required to have allowed `Put`
dkirillov commented 2024-08-21 12:44:42 +00:00
Outdated
Review
Copy link

Can we use the same oprerations as for s3:PutObject with additional (native:Patch)? So I also suggest add MethodRangeObject

Can we use the same oprerations as for `s3:PutObject` with additional (native:Patch)? So I also suggest add `MethodRangeObject`
mbiryukova commented 2024-08-21 13:34:36 +00:00
Outdated
Review
Copy link

Added

Added
}
var containerNativeOperations = map[string]struct{}{

1
iam/converter_s3.go
View file

@ -32,6 +32,7 @@ var actionToS3OpMap = map[string][]string{
s3ActionPutObjectLegalHold: {s3ActionPutObjectLegalHold},
s3ActionPutObjectRetention: {s3ActionPutObjectRetention},
s3ActionPutObjectTagging: {s3ActionPutObjectTagging},
s3ActionPatchObject: {s3ActionPatchObject},
s3ActionListAllMyBuckets: {"s3:ListBuckets"},
s3ActionListBucket: {"s3:HeadBucket", "s3:GetBucketLocation", "s3:ListObjectsV1", "s3:ListObjectsV2"},