TrueCloudLab/restic
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

[#1] Add frostfs backend #1

Open
KurlesHS wants to merge 1 commit from KurlesHS/restic:feature/add-frostfs-support into tcl/master
pull from: KurlesHS/restic:feature/add-frostfs-support
merge into: TrueCloudLab:tcl/master
Conversation 0 Commits 1 Files changed 8 +936 -9
KurlesHS commented 2024-12-10 13:13:31 +00:00
Member
Copy link

Signed-off-by: Aleksey Kravchenko al.kravchenko@yadro.com

Signed-off-by: Aleksey Kravchenko <al.kravchenko@yadro.com>
KurlesHS added 1 commit 2024-12-10 13:13:32 +00:00
[#XX] Add frostfs backend
Some checks failed
test / lint (pull_request) Failing after 3m19s
Details
test / Cross Compile for subset 2/3 (pull_request) Failing after 4m57s
Details
test / docker (pull_request) Failing after 6m11s
Details
test / Linux Go 1.19.x (pull_request) Failing after 7m7s
Details
test / Linux Go 1.20.x (pull_request) Failing after 8m48s
Details
test / Cross Compile for subset 0/3 (pull_request) Successful in 9m52s
Details
test / Cross Compile for subset 1/3 (pull_request) Successful in 10m37s
Details
test / Linux Go 1.21.x (pull_request) Failing after 13m4s
Details
test / Linux Go 1.22.x (pull_request) Failing after 13m3s
Details
test / Linux (race) Go 1.22.x (pull_request) Failing after 15m33s
Details
test / Windows Go 1.22.x (pull_request) Has been cancelled
Details
test / macOS Go 1.22.x (pull_request) Has been cancelled
Details
test / Analyze results (pull_request) Has been cancelled
Details
f9c3130c1b 
Signed-off-by: Aleksey Kravchenko <al.kravchenko@yadro.com>
KurlesHS force-pushed feature/add-frostfs-support from f9c3130c1b to 0eda218df2 2024-12-10 13:14:55 +00:00 Compare
KurlesHS changed title from [#XX] Add frostfs backend to [#1] Add frostfs backend 2024-12-10 13:15:10 +00:00
KurlesHS self-assigned this 2024-12-10 13:40:08 +00:00
KurlesHS requested review from storage-services-committers 2024-12-10 13:43:13 +00:00
KurlesHS requested review from storage-services-developers 2024-12-10 13:43:14 +00:00
alexvanin reviewed 2024-12-11 14:49:34 +00:00
internal/backend/frostfs/frostfs.go Outdated
@ -0,0 +93,4 @@
return nil // nil is valid value
}
func (b *Backend) Test(ctx context.Context, h backend.Handle) (bool, error) {
alexvanin commented 2024-12-11 14:44:45 +00:00
Owner
Copy link

Maybe we can simplify Test function. If I understand correctly, Test is called to check if connection to the backend is active. Correct me if I am wrong.

To perform healthcheck we can call NetmapSnapshot. Searches are quite expensive, so it would be nice to avoid them if we can.

Maybe we can simplify `Test` function. If I understand correctly, `Test` is called to check if connection to the backend is active. Correct me if I am wrong. To perform healthcheck we can call [NetmapSnapshot](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/d86cf85b391ecfbcaffba2eba1c92c94f494795d/pool/pool.go#L3149). Searches are quite expensive, so it would be nice to avoid them if we can.
KurlesHS commented 2024-12-12 10:57:02 +00:00
Author
Member
Copy link

Moreover, in this version of restic, we can simplify it even more by completely removing this method, since its definition has been removed from the backend.Backend intreface.

But in the original implementation, this method was used to check for the presence of a specific file.

Moreover, in this version of restic, we can simplify it even more by completely removing this method, since its definition has been removed from the `backend.Backend` intreface. But in the original implementation, this method was used to check for the presence of a specific file.
alexvanin commented 2024-12-13 11:40:51 +00:00
Owner
Copy link

Let's remove all unused methods including Test.

Let's remove all unused methods including `Test`.
internal/backend/frostfs/frostfs.go Outdated
@ -0,0 +312,4 @@
return strings.Contains(err.Error(), "not found")
}
func (b *Backend) Delete(ctx context.Context) error {
alexvanin commented 2024-12-11 14:49:30 +00:00
Owner
Copy link

Can you provide some details when this call happens? As far as I see, container ID is provided by restic config. So it feels a bit wrong to delete this container in runtime somehow.

Can you provide some details when this call happens? As far as I see, container ID is provided by restic config. So it feels a bit wrong to delete this container in runtime somehow.
KurlesHS commented 2024-12-12 11:12:06 +00:00
Author
Member
Copy link

This method is used in two other methods, and these methods are not called anywhere else. I looked into the s3 backend implementation of this method: all archive files are deleted there, but the bucket itself is not deleted. I can do the same in the FrostFS backend.

This method is used in two other methods, and these methods are not called anywhere else. I looked into the s3 backend implementation of this method: all archive files are deleted there, but the bucket itself is not deleted. I can do the same in the FrostFS backend.
alexvanin commented 2024-12-13 11:44:58 +00:00
Owner
Copy link

Can you elaborate what is arhive object that S3 removes in Delete method?

Maybe we decided to optimize clean-up stage with this code in the past. S3 protocol does not allow to remove bucket until all objects are removed. FrostFS allows to remove container.

If it is not called at all, I guess we can keep current implementation for now.

Can you elaborate what is _arhive_ object that S3 removes in `Delete` method? Maybe we decided to optimize clean-up stage with this code in the past. S3 protocol does not allow to remove bucket until all objects are removed. FrostFS allows to remove container. If it is not called at all, I guess we can keep current implementation for now.
KurlesHS commented 2024-12-13 13:38:30 +00:00
Author
Member
Copy link

Can you elaborate what is arhive object that S3 removes in Delete method?

If I understood the question correctly, the s3 backend, when executing the Delete method, deletes all files generated within the backup from the package, after which there are no files left in it. The bucket itself is not deleted. The implementation of this method is shown below:

// Delete remove all restic keys in the bucket. It will not remove the bucket itself.
func (be *Backend) Delete(ctx context.Context) error {
	return util.DefaultDelete(ctx, be)
}

The util.DefaultDelete function accepts an interface implementing a particular backend as input and deletes all backup files generated by this backend.

Under the hood, util.DefaultDelete reads the list of files from the "config" file, deletes these files, and then also deletes the aforementioned "config" file

So we can implement our Delete method in the same way as it is done in s3 backend.

Maybe we decided to optimize clean-up stage with this code in the past. S3 protocol does not allow to remove bucket until all objects are removed. FrostFS allows to remove container.

If it is not called at all, I guess we can keep current implementation for now.

Or we can leave the current implementation.

> Can you elaborate what is _arhive_ object that S3 removes in `Delete` method? If I understood the question correctly, the s3 backend, when executing the Delete method, deletes all files generated within the backup from the package, after which there are no files left in it. The bucket itself is not deleted. The implementation of this method is shown below: ``` // Delete remove all restic keys in the bucket. It will not remove the bucket itself. func (be *Backend) Delete(ctx context.Context) error { return util.DefaultDelete(ctx, be) } ``` The util.DefaultDelete function accepts an interface implementing a particular backend as input and deletes all backup files generated by this backend. Under the hood, util.DefaultDelete reads the list of files from the "config" file, deletes these files, and then also deletes the aforementioned "config" file So we can implement our Delete method in the same way as it is done in s3 backend. > Maybe we decided to optimize clean-up stage with this code in the past. S3 protocol does not allow to remove bucket until all objects are removed. FrostFS allows to remove container. > > If it is not called at all, I guess we can keep current implementation for now. Or we can leave the current implementation.
alexvanin marked this conversation as resolved
alexvanin requested changes 2024-12-13 11:45:58 +00:00
alexvanin left a comment
Owner
Copy link

Remove unused Test backend function and check if there are any more function that are unused.

Remove unused `Test` backend function and check if there are any more function that are unused.
KurlesHS force-pushed feature/add-frostfs-support from 0eda218df2 to 6939e0353f 2024-12-13 13:49:01 +00:00 Compare
Some checks failed
test / docker (pull_request) Failing after 1m59s
Details
test / Cross Compile for subset 2/3 (pull_request) Failing after 4m22s
Details
test / Linux Go 1.20.x (pull_request) Failing after 4m28s
Details
test / lint (pull_request) Failing after 4m33s
Details
test / Linux Go 1.19.x (pull_request) Failing after 7m9s
Details
test / Linux Go 1.22.x (pull_request) Failing after 8m43s
Details
test / Linux Go 1.21.x (pull_request) Failing after 9m5s
Details
test / Cross Compile for subset 0/3 (pull_request) Successful in 10m38s
Details
test / Linux (race) Go 1.22.x (pull_request) Failing after 10m59s
Details
test / Cross Compile for subset 1/3 (pull_request) Successful in 12m24s
Details
test / Windows Go 1.22.x (pull_request) Has been cancelled
Details
test / macOS Go 1.22.x (pull_request) Has been cancelled
Details
test / Analyze results (pull_request) Has been cancelled
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/add-frostfs-support:KurlesHS-feature/add-frostfs-support
git checkout KurlesHS-feature/add-frostfs-support
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
KurlesHS
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/restic#1
No description provided.
Delete branch "KurlesHS/restic:feature/add-frostfs-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?