Change license and update leftovers #3

2023-02-10T13:59:33Z

realloc commented

2023-02-10 13:59:33 +00:00

(Migrated from github.com)

Change license to Apache 2.0 to match SDK
Simplify Makefile
Update contribution guide

- Change license to Apache 2.0 to match SDK - Simplify Makefile - Update contribution guide

anatoly-bogatyrev (Migrated from github.com) approved these changes 2023-02-10 14:11:09 +00:00

fyrchik (Migrated from github.com) reviewed 2023-02-10 16:02:31 +00:00

CONTRIBUTING.md

													
				@ -0,0 +78,4 @@

				```

				```

				$ git commit -sam '[#123] Add some feature'

fyrchik (Migrated from github.com) commented

2023-02-10 15:54:45 +00:00

This repo historically does not add issue numbers. Ironically, this PR too. Do we want to start?
I would stay with the old approach given the amount of changes we have here.

This repo historically does not add issue numbers. Ironically, this PR too. Do we want to start? I would stay with the old approach given the amount of changes we have here.

LICENSE

fyrchik (Migrated from github.com) commented

2023-02-10 15:58:57 +00:00

Written approvals from all original authors were received

RLY? 😄

> Written approvals from all original authors were received RLY? :smile:

demo.sh

fyrchik (Migrated from github.com) commented

2023-02-10 16:01:04 +00:00

TMPDI?

`TMPDI`?

fyrchik (Migrated from github.com) commented

2023-02-10 16:02:15 +00:00

Why backtick and not $()?
shellcheck usually complains.

Why backtick and not `$()`? `shellcheck` usually complains.

realloc (Migrated from github.com) reviewed 2023-02-10 17:02:07 +00:00

CONTRIBUTING.md

													
				@ -0,0 +78,4 @@

				```

				```

				$ git commit -sam '[#123] Add some feature'

realloc (Migrated from github.com) commented

2023-02-10 17:02:07 +00:00

I propose to use a common style across all repositories here.

realloc (Migrated from github.com) reviewed 2023-02-10 17:03:32 +00:00

LICENSE

realloc (Migrated from github.com) commented

2023-02-10 17:03:32 +00:00

Of course! =)

realloc (Migrated from github.com) reviewed 2023-02-10 17:13:11 +00:00

demo.sh

realloc (Migrated from github.com) commented

2023-02-10 17:13:11 +00:00

Agree. A blast from the past =)

realloc (Migrated from github.com) reviewed 2023-02-10 17:23:34 +00:00

CONTRIBUTING.md

													
				@ -0,0 +78,4 @@

				```

				```

				$ git commit -sam '[#123] Add some feature'

realloc (Migrated from github.com) commented

2023-02-10 17:23:34 +00:00

And I hope we could have more changes coming.

fyrchik (Migrated from github.com) reviewed 2023-02-13 11:10:37 +00:00

CONTRIBUTING.md

													
				@ -0,0 +78,4 @@

				```

				```

				$ git commit -sam '[#123] Add some feature'

fyrchik (Migrated from github.com) commented

2023-02-13 11:10:37 +00:00

Then again, what about this PR?

realloc (Migrated from github.com) reviewed 2023-02-13 11:30:08 +00:00

CONTRIBUTING.md

													
				@ -0,0 +78,4 @@

				```

				```

				$ git commit -sam '[#123] Add some feature'

realloc (Migrated from github.com) commented

2023-02-13 11:30:08 +00:00

Added proper references in commit summary. I promise to split similar bulk changes in to several logically smaller PRs next time =)

fyrchik (Migrated from github.com) approved these changes 2023-02-13 12:16:08 +00:00

Sign in to join this conversation.

No reviewers

anatoly-bogatyrev

fyrchik

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/tzhash#3