TrueCloudLab/tzhash
15
0
Fork 6
Code Issues 3 Pull requests Releases 2 Activity

Change license and update leftovers #3

Merged
realloc merged 4 commits from fix/license into master 2023-02-13 12:16:26 +00:00
Conversation 0 Commits 4 Files changed 9 +515 -792
realloc commented 2023-02-10 13:59:33 +00:00 (Migrated from github.com)
Copy link
  • Change license to Apache 2.0 to match SDK
  • Simplify Makefile
  • Update contribution guide
- Change license to Apache 2.0 to match SDK - Simplify Makefile - Update contribution guide
anatoly-bogatyrev (Migrated from github.com) approved these changes 2023-02-10 14:11:09 +00:00
fyrchik (Migrated from github.com) reviewed 2023-02-10 16:02:31 +00:00
CONTRIBUTING.md
@ -0,0 +78,4 @@
```
```
$ git commit -sam '[#123] Add some feature'
fyrchik (Migrated from github.com) commented 2023-02-10 15:54:45 +00:00
Copy link

This repo historically does not add issue numbers. Ironically, this PR too. Do we want to start?
I would stay with the old approach given the amount of changes we have here.

This repo historically does not add issue numbers. Ironically, this PR too. Do we want to start? I would stay with the old approach given the amount of changes we have here.
LICENSE
fyrchik (Migrated from github.com) commented 2023-02-10 15:58:57 +00:00
Copy link

Written approvals from all original authors were received

RLY? 😄

> Written approvals from all original authors were received RLY? :smile:
demo.sh
fyrchik (Migrated from github.com) commented 2023-02-10 16:01:04 +00:00
Copy link

TMPDI?

`TMPDI`?
fyrchik (Migrated from github.com) commented 2023-02-10 16:02:15 +00:00
Copy link

Why backtick and not $()?
shellcheck usually complains.

Why backtick and not `$()`? `shellcheck` usually complains.
realloc (Migrated from github.com) reviewed 2023-02-10 17:02:07 +00:00
CONTRIBUTING.md
@ -0,0 +78,4 @@
```
```
$ git commit -sam '[#123] Add some feature'
realloc (Migrated from github.com) commented 2023-02-10 17:02:07 +00:00
Copy link

I propose to use a common style across all repositories here.

I propose to use a common style across all repositories here.
realloc (Migrated from github.com) reviewed 2023-02-10 17:03:32 +00:00
LICENSE
realloc (Migrated from github.com) commented 2023-02-10 17:03:32 +00:00
Copy link

Of course! =)

Of course! =)
realloc (Migrated from github.com) reviewed 2023-02-10 17:13:11 +00:00
demo.sh
realloc (Migrated from github.com) commented 2023-02-10 17:13:11 +00:00
Copy link

Agree. A blast from the past =)

Agree. A blast from the past =)
realloc (Migrated from github.com) reviewed 2023-02-10 17:23:34 +00:00
CONTRIBUTING.md
@ -0,0 +78,4 @@
```
```
$ git commit -sam '[#123] Add some feature'
realloc (Migrated from github.com) commented 2023-02-10 17:23:34 +00:00
Copy link

And I hope we could have more changes coming.

And I hope we could have more changes coming.
fyrchik (Migrated from github.com) reviewed 2023-02-13 11:10:37 +00:00
CONTRIBUTING.md
@ -0,0 +78,4 @@
```
```
$ git commit -sam '[#123] Add some feature'
fyrchik (Migrated from github.com) commented 2023-02-13 11:10:37 +00:00
Copy link

Then again, what about this PR?

Then again, what about this PR?
realloc (Migrated from github.com) reviewed 2023-02-13 11:30:08 +00:00
CONTRIBUTING.md
@ -0,0 +78,4 @@
```
```
$ git commit -sam '[#123] Add some feature'
realloc (Migrated from github.com) commented 2023-02-13 11:30:08 +00:00
Copy link

Added proper references in commit summary. I promise to split similar bulk changes in to several logically smaller PRs next time =)

Added proper references in commit summary. I promise to split similar bulk changes in to several logically smaller PRs next time =)
fyrchik (Migrated from github.com) approved these changes 2023-02-13 12:16:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
anatoly-bogatyrev
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/tzhash#3
No description provided.
Delete branch "fix/license"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?