Allow to specify max_obj_size #145

dstepanov-yadro · 2024-06-14T07:44:05Z

dstepanov-yadro commented

2024-06-14 07:44:05 +00:00

Allow to override MAX_OBJECT_SIZE value for native protocol for locally prepared objects.
Tested on local setup.

Allow to override MAX_OBJECT_SIZE value for native protocol for locally prepared objects. Tested on local setup.

dstepanov-yadro requested review from storage-core-committers 2024-06-14 07:57:14 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-06-14 07:57:15 +00:00

dstepanov-yadro force-pushed feat/max_obj_size from 534ad7ff9b to 6d1e7eb49e

2024-06-14 07:57:47 +00:00

Compare

aarifullin approved these changes 2024-06-14 07:57:55 +00:00

achuprov approved these changes 2024-06-14 08:02:23 +00:00

acid-ant approved these changes 2024-06-14 08:12:57 +00:00

fyrchik reviewed 2024-06-14 08:16:14 +00:00

internal/native/native.go

					
				@ -117,0 +123,4 @@

						if err != nil {

							return nil, err

						}

						if uint64(maxObjSize) > res.Info().MaxObjectSize() {

fyrchik commented

2024-06-14 08:16:14 +00:00

We fetch network info in put(), why not validate there?
We can use the same client and multiple sizes in the same scenario, so maxObjSize is unrelated to Connect

We fetch network info in `put()`, why not validate there? We can use the same client and multiple sizes in the same scenario, so `maxObjSize` is unrelated to `Connect`

fyrchik marked this conversation as resolved

dstepanov-yadro added 1 commit 2024-06-14 08:27:07 +00:00

[#145 ] scenarios: Format js files with clang

DCO action / DCO (pull_request) Successful in 1m18s

Details

Tests and linters / Tests (1.22) (pull_request) Successful in 3m10s

Details

Tests and linters / Tests (1.21) (pull_request) Successful in 3m27s

Details

Tests and linters / Tests with -race (pull_request) Successful in 3m28s

Details

Tests and linters / Lint (pull_request) Successful in 4m29s

Details

e92ce668a8

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

fyrchik merged commit e92ce668a8 into master

2024-06-14 08:31:38 +00:00

fyrchik referenced this pull request from a commit

2024-06-14 08:31:40 +00:00

[#145] native: Allow to specify max_obj_size

fyrchik referenced this pull request from a commit

2024-06-14 08:31:40 +00:00

[#145] scenarios: Format js files with clang

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

5 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#145