TrueCloudLab/xk6-frostfs
42
1
Fork 20
Code Issues 34 Pull requests 2 Releases Activity Actions

[#194] s3local: Change fixedBucketResolver behavior #194

Open
dkirillov wants to merge 1 commit from dkirillov/xk6-frostfs:bugfix/correct_local_bucket_resolving into master
pull from: dkirillov/xk6-frostfs:bugfix/correct_local_bucket_resolving
merge into: TrueCloudLab:master
Conversation 3 Commits 1 Files changed 2 +6 -7
dkirillov commented 2025-01-24 09:30:55 +00:00
Member
Copy link

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2025-01-24 09:30:55 +00:00
dkirillov added 1 commit 2025-01-24 09:30:55 +00:00
[#XX] s3local: Fixed bucket resolver should not use zone
All checks were successful
DCO action / DCO (pull_request) Successful in 27s
Details
Tests and linters / Tests (pull_request) Successful in 1m46s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m9s
Details
Tests and linters / Lint (pull_request) Successful in 2m57s
Details
40c356f691 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov changed title from WIP: [#XX] s3local: Fixed bucket resolver should not use zone to WIP: [#194] s3local: Fixed bucket resolver should not use zone 2025-01-24 09:31:08 +00:00
dkirillov force-pushed bugfix/correct_local_bucket_resolving from 40c356f691 to 59e59e1eea 2025-01-24 09:31:32 +00:00 Compare
dkirillov changed title from WIP: [#194] s3local: Fixed bucket resolver should not use zone to [#194] s3local: Fixed bucket resolver should not use zone 2025-01-24 09:31:35 +00:00
requested reviews from storage-services-committers, storage-services-developers, storage-core-committers, storage-core-developers 2025-01-24 09:31:35 +00:00
fyrchik requested changes 2025-01-24 10:05:46 +00:00
fyrchik left a comment
Owner
Copy link

Please, start the commit message with the verb in imperative.

Please, start the commit message with the verb in imperative.
dkirillov force-pushed bugfix/correct_local_bucket_resolving from 59e59e1eea to d05ad5d3c5 2025-01-24 13:16:59 +00:00 Compare
dkirillov changed title from [#194] s3local: Fixed bucket resolver should not use zone to [#194] s3local: Fix bucket resolver should not use zone 2025-01-24 13:17:02 +00:00
dkirillov force-pushed bugfix/correct_local_bucket_resolving from d05ad5d3c5 to 51ba40eaac 2025-01-24 13:17:58 +00:00 Compare
dkirillov changed title from [#194] s3local: Fix bucket resolver should not use zone to [#194] s3local: Fixed bucket resolver should not use zone 2025-01-24 13:18:19 +00:00
dkirillov changed title from [#194] s3local: Fixed bucket resolver should not use zone to [#194] s3local: Bucket resolver should not use zone 2025-01-24 13:18:31 +00:00
dkirillov changed title from [#194] s3local: Bucket resolver should not use zone to [#194] s3local: Change fixedBucketResolver behavior 2025-01-24 13:18:46 +00:00
dkirillov commented 2025-01-24 13:21:18 +00:00
Author
Member
Copy link

Please, start the commit message with the verb in imperative.

Actually, the fixed word was an adverb (fixedBucketResolver) rather than verb.

I've change commit message to be more clear

> Please, start the commit message with the verb in imperative. Actually, the `fixed` word was an adverb (`fixedBucketResolver`) rather than verb. I've change commit message to be more clear
alexvanin approved these changes 2025-01-29 14:10:08 +00:00
acid-ant approved these changes 2025-01-31 12:29:51 +00:00
dkirillov commented 2025-02-04 08:36:15 +00:00
Author
Member
Copy link

@mmalygina does this PR fix problem?

@mmalygina does this PR fix problem?
mmalygina commented 2025-02-05 13:21:04 +00:00
Member
Copy link

Yes, PR fixes the problem

Yes, PR fixes the problem
dkirillov scheduled this pull request to auto merge when all checks succeed 2025-02-06 13:34:12 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 29s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m1s
Details
Tests and linters / Tests (pull_request) Successful in 2m1s
Details
Tests and linters / Lint (pull_request) Successful in 2m17s
Details
This pull request has changes requested by an official reviewer.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u bugfix/correct_local_bucket_resolving:dkirillov-bugfix/correct_local_bucket_resolving
git checkout dkirillov-bugfix/correct_local_bucket_resolving
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
alexvanin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#194
No description provided.
Delete branch "dkirillov/xk6-frostfs:bugfix/correct_local_bucket_resolving"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?