TrueCloudLab/xk6-frostfs
42
1
Fork 20
Code Issues 32 Pull requests 2 Releases Activity Actions

[#11] Support reading env variables from file #34

Merged
fyrchik merged 1 commit from dkirillov/xk6-frostfs:feature/11-read_env_file into master 2023-03-20 13:02:07 +00:00
Conversation 0 Commits 1 Files changed 10 +82
dkirillov commented 2023-03-14 15:05:13 +00:00
Member
Copy link

close #11

close #11
dkirillov self-assigned this 2023-03-14 15:05:13 +00:00
dkirillov force-pushed feature/11-read_env_file from 04e22cda74 to c39384f44b 2023-03-15 06:09:25 +00:00 Compare
dkirillov force-pushed feature/11-read_env_file from c39384f44b to ed58333aba 2023-03-15 06:13:50 +00:00 Compare
dkirillov changed title from WIP: [#11] Support reading env variables from file to [#11] Support reading env variables from file 2023-03-15 06:14:22 +00:00
requested reviews from fyrchik, a.bogatyrev, alexvanin, carpawell, abereziny 2023-03-15 06:16:31 +00:00
acid-ant approved these changes 2023-03-15 06:28:30 +00:00
alexvanin approved these changes 2023-03-16 12:29:32 +00:00
scenarios/s3.js
@ -7,1 +7,4 @@
import { textSummary } from './libs/k6-summary-0.0.2.js';
import { parseEnv } from './libs/env-parser.js';
parseEnv();
alexvanin commented 2023-03-16 12:28:42 +00:00
Owner
Copy link

Is this required to use -e ENV_FILE=.env?

Is this required to use `-e ENV_FILE=.env`?
dkirillov commented 2023-03-16 15:18:18 +00:00
Author
Member
Copy link

No, there is some check in parseEnv() function

No, there is some check in `parseEnv()` function
fyrchik approved these changes 2023-03-16 17:25:40 +00:00
dkirillov scheduled this pull request to auto merge when all checks succeed 2023-03-20 08:06:32 +00:00
realloc canceled auto merging this pull request when all checks succeed 2023-03-20 08:25:43 +00:00
requested reviews from acid-ant, alexvanin, fyrchik 2023-03-20 08:37:53 +00:00
requested reviews from storage-core-committers, storage-core-developers, storage-services-committers, storage-services-developers 2023-03-20 08:38:15 +00:00
alexvanin approved these changes 2023-03-20 08:43:20 +00:00
fyrchik merged commit ed58333aba into master 2023-03-20 13:02:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a.bogatyrev
carpawell
abereziny
acid-ant
fyrchik
alexvanin
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#34
No description provided.
Delete branch "dkirillov/xk6-frostfs:feature/11-read_env_file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?