[#11] Support reading env variables from file #34

dkirillov · 2023-03-14T15:05:13Z

dkirillov commented

2023-03-14 15:05:13 +00:00

close #11

dkirillov self-assigned this 2023-03-14 15:05:13 +00:00

dkirillov force-pushed feature/11-read_env_file from 04e22cda74 to c39384f44b

2023-03-15 06:09:25 +00:00

Compare

dkirillov force-pushed feature/11-read_env_file from c39384f44b to ed58333aba

2023-03-15 06:13:50 +00:00

Compare

dkirillov changed title from ~~WIP: [#11] Support reading env variables from file~~ to [#11] Support reading env variables from file

2023-03-15 06:14:22 +00:00

dkirillov requested review from fyrchik 2023-03-15 06:15:31 +00:00

dkirillov requested review from a.bogatyrev 2023-03-15 06:15:31 +00:00

dkirillov requested review from alexvanin 2023-03-15 06:15:31 +00:00

dkirillov requested review from carpawell 2023-03-15 06:16:30 +00:00

dkirillov requested review from abereziny 2023-03-15 06:16:31 +00:00

acid-ant approved these changes 2023-03-15 06:28:30 +00:00

alexvanin approved these changes 2023-03-16 12:29:32 +00:00

scenarios/s3.js

													
				@ -7,1 +7,4 @@

				import { textSummary } from './libs/k6-summary-0.0.2.js';

				import { parseEnv } from './libs/env-parser.js';

				parseEnv();

alexvanin commented

2023-03-16 12:28:42 +00:00

Is this required to use -e ENV_FILE=.env?

Is this required to use `-e ENV_FILE=.env`?

dkirillov commented

2023-03-16 15:18:18 +00:00

Poster

No, there is some check in parseEnv() function

No, there is some check in `parseEnv()` function

fyrchik approved these changes 2023-03-16 17:25:40 +00:00

dkirillov scheduled this pull request to auto merge when all checks succeed 2023-03-20 08:06:32 +00:00

realloc canceled auto merging this pull request when all checks succeed 2023-03-20 08:25:43 +00:00

realloc requested review from acid-ant 2023-03-20 08:37:49 +00:00

realloc requested review from alexvanin 2023-03-20 08:37:51 +00:00

realloc requested review from fyrchik 2023-03-20 08:37:53 +00:00

dkirillov requested review from storage-core-committers 2023-03-20 08:38:15 +00:00

dkirillov requested review from storage-core-developers 2023-03-20 08:38:15 +00:00

dkirillov requested review from storage-services-committers 2023-03-20 08:38:15 +00:00

dkirillov requested review from storage-services-developers 2023-03-20 08:38:15 +00:00

alexvanin approved these changes 2023-03-20 08:43:20 +00:00

fyrchik merged commit ed58333aba into master

2023-03-20 13:02:07 +00:00

fyrchik referenced this pull request

2023-03-24 08:31:15 +00:00

scenarios: Support ENV file in local.js #45

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-committers

TrueCloudLab/storage-core-developers

TrueCloudLab/storage-services-developers

No Label

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#34