Use default HTTP client instead of requests #105

dstepanov-yadro · 2023-11-17T11:43:22Z

dstepanov-yadro commented

2023-11-17 11:43:22 +00:00

requests lib is not default, so it can be unavailable.

Closes #104

`requests` lib is not default, so it can be unavailable. Closes #104

dstepanov-yadro added 1 commit 2023-11-17 11:43:25 +00:00

[#104 ] s3local: Use default HTTP client instead of requests

DCO action / DCO (pull_request) Successful in 1m51s

Details

Tests and linters / Tests (1.21) (pull_request) Successful in 2m55s

Details

Tests and linters / Tests with -race (pull_request) Successful in 3m20s

Details

Tests and linters / Tests (1.20) (pull_request) Successful in 3m33s

Details

3574361f2e

`requests` lib is not default, so it can be unavailable.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

fyrchik approved these changes 2023-11-17 11:51:13 +00:00

scenarios/preset/resolve_containers_in_preset.py

					
				@ -16,10 +17,13 @@ def main():

				    preset = json.loads(preset_text)

				    conn = http.client.HTTPSConnection(args.endpoint, context = ssl._create_unverified_context())

fyrchik commented

2023-11-17 11:50:56 +00:00

Is is always HTTPS?

Is is always `HTTPS`?

dstepanov-yadro commented

2023-11-17 11:53:51 +00:00

s3-gate uses https by default (on dev-env and production). So I decided not to add additional parameters or logic.

acid-ant approved these changes 2023-11-17 11:57:56 +00:00

dstepanov-yadro merged commit 3574361f2e into master

2023-11-17 11:59:57 +00:00

dstepanov-yadro deleted branch fix/drop_requests_dep

2023-11-17 11:59:59 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#105

Use default HTTP client instead of requests #105

Use default HTTP client instead of `requests` #105