TrueCloudLab/xk6-frostfs
42
1
Fork 20
Code Issues 35 Pull requests 2 Releases Activity Actions

Do not store all payload in memory #115

Merged
fyrchik merged 5 commits from fyrchik/xk6-frostfs:streaming_payload into master 2024-09-04 19:51:18 +00:00
Conversation 0 Commits 5 Files changed 22 +260 -83
fyrchik commented 2024-01-11 19:16:59 +00:00
Owner
Copy link

Close #114

The number of parameters continues to grow, the future looks grim, so #116 was created.

TBD all the testing

Close #114 The number of parameters continues to grow, the future looks grim, so #116 was created. TBD all the testing
fyrchik requested review from storage-core-committers 2024-01-11 19:17:11 +00:00
fyrchik requested review from storage-core-developers 2024-01-11 19:17:12 +00:00
fyrchik requested review from storage-services-committers 2024-01-11 19:17:12 +00:00
fyrchik requested review from storage-services-developers 2024-01-11 19:17:13 +00:00
fyrchik requested review from vdomnich-yadro 2024-01-11 19:19:13 +00:00
fyrchik force-pushed streaming_payload from 2f726c59b2 to ca26da827c 2024-01-11 19:32:31 +00:00 Compare
fyrchik force-pushed streaming_payload from ca26da827c to ee6af36ee8 2024-01-11 19:36:59 +00:00 Compare
fyrchik reviewed 2024-01-11 19:46:46 +00:00
scenarios/http.js Outdated
@ -102,3 +102,3 @@
const data = {
field: uuidv4(),
file: http.file(payload, "random.data"),
file: http.file(payload, "random.data"), // FIXME
fyrchik commented 2024-01-11 19:46:46 +00:00
Author
Owner
Copy link

This is so annoying, haven't yet come up with a solution, will fix in this PR, thus WIP

This is so annoying, haven't yet come up with a solution, will fix in this PR, thus WIP
fyrchik commented 2024-01-11 20:38:42 +00:00
Author
Owner
Copy link

04a8119ef3/js/modules/k6/http/file.go (L25)

https://github.com/grafana/k6/blob/04a8119ef33b6b12c0210bb05c80e8da9bb1a823/js/modules/k6/http/file.go#L25
fyrchik commented 2024-01-12 16:56:22 +00:00
Author
Owner
Copy link

Decided to avoid streaming for http scenario.

Decided to avoid streaming for http scenario.
fyrchik marked this conversation as resolved
fyrchik changed title from Do not store all payload in memory to WIP: Do not store all payload in memory 2024-01-11 19:48:53 +00:00
fyrchik force-pushed streaming_payload from ee6af36ee8 to 62e754b649 2024-01-12 08:09:13 +00:00 Compare
dstepanov-yadro approved these changes 2024-01-12 09:09:34 +00:00
fyrchik force-pushed streaming_payload from 62e754b649 to d36517d9fe 2024-01-12 13:59:27 +00:00 Compare
fyrchik force-pushed streaming_payload from d36517d9fe to fda5e5b3ca 2024-01-12 16:22:24 +00:00 Compare
fyrchik force-pushed streaming_payload from fda5e5b3ca to 51f86ec2c6 2024-01-12 16:29:31 +00:00 Compare
fyrchik changed title from WIP: Do not store all payload in memory to Do not store all payload in memory 2024-01-12 16:29:33 +00:00
fyrchik force-pushed streaming_payload from 51f86ec2c6 to 339e4e52ec 2024-01-12 16:35:35 +00:00 Compare
acid-ant approved these changes 2024-01-15 08:07:29 +00:00
aarifullin approved these changes 2024-01-15 08:16:51 +00:00
fyrchik merged commit 339e4e52ec into master 2024-01-17 11:16:00 +00:00
fyrchik deleted branch streaming_payload 2024-01-17 11:16:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
vdomnich-yadro
dstepanov-yadro
acid-ant
aarifullin
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#115
No description provided.
Delete branch "fyrchik/xk6-frostfs:streaming_payload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?