Adding acl to container and bucket creation #128

Merged
abereziny merged 1 commit from abereziny/xk6-frostfs:feature-add-acl-argument into master 2024-02-06 11:59:28 +00:00
Member

Closes #125

Signed-off-by: Andrey Berezin a.berezin@yadro.com

Closes #125 Signed-off-by: Andrey Berezin <a.berezin@yadro.com>
abereziny added 1 commit 2024-02-05 15:57:14 +00:00
[#125] Adding acl to container and bucket creation
Some checks reported warnings
DCO action / DCO (pull_request) Has been cancelled
Tests and linters / Lint (pull_request) Has been cancelled
Tests and linters / Tests (1.20) (pull_request) Has been cancelled
Tests and linters / Tests (1.21) (pull_request) Has been cancelled
Tests and linters / Tests with -race (pull_request) Has been cancelled
47fc031028
Signed-off-by: Andrey Berezin <a.berezin@yadro.com>
abereziny changed title from [#125] Adding acl to container and bucket creation to Adding acl to container and bucket creation 2024-02-05 15:58:00 +00:00
abereziny requested review from storage-core-committers 2024-02-05 15:58:13 +00:00
abereziny requested review from storage-core-developers 2024-02-05 15:58:14 +00:00
abereziny requested review from storage-services-committers 2024-02-05 15:58:14 +00:00
abereziny requested review from storage-services-developers 2024-02-05 15:58:14 +00:00
d.zayakin approved these changes 2024-02-05 16:17:08 +00:00
anikeev-yadro approved these changes 2024-02-06 06:18:01 +00:00
dkirillov reviewed 2024-02-06 06:35:49 +00:00
@ -35,6 +35,7 @@ parser.add_argument('--workers', help='Count of workers in preset. Max = 50, Def
parser.add_argument('--sleep', help='Time to sleep between containers creation and objects upload (in seconds), '
'Default = 8', default=8)
parser.add_argument('--local', help='Create containers that store data on provided endpoints. Warning: additional empty containers may be created.', action='store_true')
parser.add_argument('--acl', help='Container ACL. Default is public-read-write.', default='public-read-write')
Member

question: Why default isn't private?

question: Why default isn't `private`?
Author
Member

@dkirillov Before the change public-read-write was hardcoded, so to support backward compatibility with anyone who uses it.

@dkirillov Before the change public-read-write was hardcoded, so to support backward compatibility with anyone who uses it.
dkirillov marked this conversation as resolved
dkirillov approved these changes 2024-02-06 06:35:55 +00:00
acid-ant approved these changes 2024-02-06 08:11:41 +00:00
abereziny merged commit 47fc031028 into master 2024-02-06 11:59:28 +00:00
abereziny deleted branch feature-add-acl-argument 2024-02-06 11:59:29 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#128
No description provided.