TrueCloudLab/xk6-frostfs
40
1
Fork 20
Code Issues 35 Pull requests 1 Releases Activity Actions

[#13] Allow to use english text in the payload #15

Merged
fyrchik merged 2 commits from fyrchik/lorem-ipsum into master 2023-06-27 11:14:06 +00:00
Conversation 2 Commits 2 Files changed 9 +58 -1562
fyrchik commented 2023-02-28 11:13:37 +00:00 (Migrated from github.com)
Copy link

Close #13.

Lorem ipsum is not english technically, but it should be compressible.

Decided to use string value, not a bool one for future extensibility (xml? VM images? data from file?) and better user experience.

TODO: testing.

Close #13. `Lorem ipsum` is not english technically, but it should be compressible. Decided to use string value, not a bool one for future extensibility (xml? VM images? data from file?) and better user experience. TODO: testing.
alexvanin (Migrated from github.com) reviewed 2023-02-28 11:13:37 +00:00
KirillovDenis (Migrated from github.com) reviewed 2023-02-28 11:13:37 +00:00
carpawell (Migrated from github.com) reviewed 2023-02-28 11:13:37 +00:00
anatoly-bogatyrev (Migrated from github.com) reviewed 2023-02-28 11:13:37 +00:00
vdomnich-yadro (Migrated from github.com) reviewed 2023-02-28 11:13:37 +00:00
anikeev-yadro (Migrated from github.com) reviewed 2023-02-28 11:13:37 +00:00
anikeev-yadro commented 2023-03-01 07:30:21 +00:00 (Migrated from github.com)
Copy link

I suggest to stop scenario with errorcode if we use wrong value. It will more convenient to autotests.

I suggest to stop scenario with errorcode if we use wrong value. It will more convenient to autotests.
anikeev-yadro commented 2023-03-01 08:00:24 +00:00 (Migrated from github.com)
Copy link

We also need to add this functionality to the preset scenario.

We also need to add this functionality to the preset scenario.
fyrchik added 1 commit 2023-03-10 07:35:41 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
acid-ant approved these changes 2023-04-03 13:30:51 +00:00
internal/datagen/generator.go Outdated
@ -47,2 +65,4 @@
buf: make([]byte, size+TailSize),
typ: typ,
}
return Generator{vu: vu, size: size, buf: nil, typ: typ, offset: 0}
acid-ant commented 2023-04-03 13:29:23 +00:00
Member
Copy link

Looks like needs to be removed.

Looks like needs to be removed.
acid-ant marked this conversation as resolved
fyrchik referenced this pull request from a commit 2023-06-25 10:25:04 +00:00
[#15] go.mod: Tidy
fyrchik force-pushed fyrchik/lorem-ipsum from 0addc11a78 to 025facee96 2023-06-25 10:26:18 +00:00 Compare
fyrchik added 1 commit 2023-06-25 10:36:09 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2023-06-25 10:36:11 +00:00
fyrchik requested review from storage-core-developers 2023-06-25 10:36:11 +00:00
fyrchik requested review from storage-services-committers 2023-06-25 10:36:12 +00:00
fyrchik requested review from storage-services-developers 2023-06-25 10:36:16 +00:00
acid-ant approved these changes 2023-06-26 06:05:27 +00:00
dstepanov-yadro approved these changes 2023-06-26 06:44:14 +00:00
alexvanin approved these changes 2023-06-27 10:39:34 +00:00
fyrchik merged commit ba04c682cb into master 2023-06-27 11:14:06 +00:00
fyrchik referenced this pull request from a commit 2023-06-27 11:14:06 +00:00
[#15] go.mod: Tidy
fyrchik deleted branch fyrchik/lorem-ipsum 2023-06-27 11:14:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
alexvanin
TrueCloudLab/storage-services-developers
alexvanin
KirillovDenis
carpawell
anatoly-bogatyrev
vdomnich-yadro
anikeev-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#15
No description provided.
Delete branch "fyrchik/lorem-ipsum"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?