TrueCloudLab
/
xk6-frostfs
38
0
Fork 15
Code Issues 30 Pull Requests Actions 4 Releases Activity

Use SelectorAwaiting in case of read and delete load in s3_dar.js scenario #150

Merged
fyrchik merged 2 commits from mmalygina/xk6-frostfs:investigate-deletes into master 2024-06-21 13:03:57 +00:00
Conversation 1 Commits 2 Files Changed 1
mmalygina commented 2024-06-20 14:05:02 +00:00
Collaborator

Use SelectorAwaiting in case of read and delete load in s3_dar.js scenario

Signed-off-by: m.malygina m.malygina@yadro.com

Use SelectorAwaiting in case of read and delete load in s3_dar.js scenario Signed-off-by: m.malygina <m.malygina@yadro.com>
mmalygina added 1 commit 2024-06-20 14:05:13 +00:00
DCO action / DCO (pull_request) Failing after 3m9s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 5m13s Details
Tests and linters / Tests with -race (pull_request) Successful in 5m11s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 5m34s Details
Tests and linters / Lint (pull_request) Successful in 3m20s Details
0b50950974 use getSelector in case of read and delete load 
Signed-off-by: m.malygina <m.malygina@yadro.com>
dstepanov-yadro approved these changes 2024-06-20 14:25:58 +00:00
fyrchik reviewed 2024-06-20 16:35:08 +00:00
scenarios/s3_dar.js Outdated
@ -76,3 +87,3 @@
let obj_to_delete_exit_on_null = undefined;
if (registry_enabled && delete_age) {
obj_to_delete_exit_on_null = write_vu_count == 0;
obj_to_delete_exit_on_null = (write_vu_count == 0) && (read_vu_count == 0)
fyrchik commented 2024-06-20 16:35:06 +00:00
Owner

How does it help?

How does it help?
mmalygina commented 2024-06-21 07:42:23 +00:00
Poster
Collaborator

In case we are running both read and delete load we don't use SelectorOneshot, but use SelectorAwaiting

In case we are running both read and delete load we don't use SelectorOneshot, but use SelectorAwaiting
mmalygina added 1 commit 2024-06-21 07:55:06 +00:00
Tests and linters / Tests (1.22) (pull_request) Failing after 18s Details
DCO action / DCO (pull_request) Failing after 1m45s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 5m4s Details
Tests and linters / Tests with -race (pull_request) Successful in 5m21s Details
Tests and linters / Lint (pull_request) Successful in 6m3s Details
c7fd2078c8 [#150] In case we are running both read and delete load SelectorAwaiting 
Signed-off-by: m.malygina <m.malygina@yadro.com>
mmalygina force-pushed investigate-deletes from c7fd2078c8 to 0a9aeab47c 2024-06-21 07:55:56 +00:00 Compare
acid-ant approved these changes 2024-06-21 08:02:26 +00:00
dstepanov-yadro approved these changes 2024-06-21 08:15:42 +00:00
fyrchik commented 2024-06-21 08:38:55 +00:00
Owner

Please, rephrase the commit message, it should start with a verb in imperative (like use). Your PR title is OK to be used as the commit message.
[#150] scenarios: Use SelectorAwaiting for read and delete load in s3_dar.js

Please, rephrase the commit message, it should start with a verb in imperative (like **use**). Your PR title is OK to be used as the commit message. `[#150] scenarios: Use SelectorAwaiting for read and delete load in s3_dar.js`
mmalygina added 1 commit 2024-06-21 12:55:22 +00:00
DCO action / DCO (pull_request) Successful in 1m28s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 3m14s Details
Tests and linters / Tests with -race (pull_request) Successful in 3m27s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 3m40s Details
Tests and linters / Lint (pull_request) Successful in 4m29s Details
e7d4dd404a [#150] scenarios: Use SelectorAwaiting for read and delete load in s3_dar.js, make delete_age optional 
Signed-off-by: m.malygina <m.malygina@yadro.com>
fyrchik merged commit e7d4dd404a into master 2024-06-21 13:03:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#150
There is no content yet.
Delete Branch "mmalygina/xk6-frostfs:investigate-deletes"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?