TrueCloudLab
/
xk6-frostfs
38
0
Fork 15
Code Issues 30 Pull Requests Actions 4 Releases Activity

[#149] selector: Add read timeout #151

Merged
dstepanov-yadro merged 1 commits from dstepanov-yadro/xk6-frostfs:feat/selector_timeout into master 2024-06-24 14:45:48 +00:00
Conversation 4 Commits 1 Files Changed 1
dstepanov-yadro commented 2024-06-24 11:01:41 +00:00
Collaborator

If there are no objects for 10 second, then return nil.
It is required to prevent VU iteration hang if there are no objects pushed to registry.

Closes #149

If there are no objects for 10 second, then return nil. It is required to prevent VU iteration hang if there are no objects pushed to registry. Closes #149
dstepanov-yadro added 1 commit 2024-06-24 11:01:54 +00:00
DCO action / DCO (pull_request) Successful in 1m15s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 3m12s Details
Tests and linters / Tests with -race (pull_request) Successful in 3m26s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 3m39s Details
Tests and linters / Lint (pull_request) Successful in 4m21s Details
335c45c578 [#149] selector: Add read timeout 
If there are no objects for 10 second, then return nil.
It is required to prevent VU iteration hang if there
are no objects pushed to registry.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro requested review from performance-committers 2024-06-24 11:02:10 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-06-24 11:02:17 +00:00
dstepanov-yadro requested review from storage-services-developers 2024-06-24 11:02:20 +00:00
acid-ant approved these changes 2024-06-24 12:10:18 +00:00
fyrchik commented 2024-06-24 13:07:39 +00:00
Owner

Seems like we need this https://github.com/grafana/k6/issues/3718

Seems like we need this https://github.com/grafana/k6/issues/3718
dstepanov-yadro commented 2024-06-24 13:37:27 +00:00
Poster
Collaborator

Seems like we need this https://github.com/grafana/k6/issues/3718

Will we wait?

> Seems like we need this https://github.com/grafana/k6/issues/3718 Will we wait?
aarifullin approved these changes 2024-06-24 13:38:26 +00:00
fyrchik commented 2024-06-24 14:03:16 +00:00
Owner

I don't mind waiting really :)

I don't mind waiting really :)
dstepanov-yadro commented 2024-06-24 14:45:36 +00:00
Poster
Collaborator

I don't mind waiting really :)

Time is running out.

> I don't mind waiting really :) Time is running out.
dstepanov-yadro merged commit 335c45c578 into master 2024-06-24 14:45:48 +00:00
dstepanov-yadro deleted branch feat/selector_timeout 2024-06-24 14:45:53 +00:00
mmalygina requested review from mmalygina 2024-06-24 14:46:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
mmalygina
TrueCloudLab/performance-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#151
There is no content yet.
Delete Branch "dstepanov-yadro/xk6-frostfs:feat/selector_timeout"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?