Delete data created in preset #157

Closed
elebedeva wants to merge 1 commit from elebedeva/xk6-frostfs:fix/delet-preset-data into master
Member

Close #154

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #154 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva added 2 commits 2024-07-26 10:30:06 +00:00
[#154] scenarios: Delete data created in preset
All checks were successful
DCO action / DCO (pull_request) Successful in 56s
Tests and linters / Tests (1.22) (pull_request) Successful in 1m28s
Tests and linters / Tests (1.21) (pull_request) Successful in 1m35s
Tests and linters / Lint (pull_request) Successful in 1m55s
Tests and linters / Tests with -race (pull_request) Successful in 2m10s
4ec75a1c89
* Currently, objects created in preset are never deleted.
  k6 deletes only objects from registry, if registry file
  is not provided k6 delete load fails.
* Changed delete scenarios so they check if registry was
  provided and if it is not empty, and if not, they try
  deleting objects created in preset.

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
[#154] scenarios: Format js files with clang formatter
All checks were successful
DCO action / DCO (pull_request) Successful in 1m4s
Tests and linters / Tests (1.21) (pull_request) Successful in 2m8s
Tests and linters / Tests (1.22) (pull_request) Successful in 2m38s
Tests and linters / Lint (pull_request) Successful in 4m6s
Tests and linters / Tests with -race (pull_request) Successful in 2m52s
5f20d5d88a
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva requested review from storage-core-committers 2024-07-26 10:30:15 +00:00
elebedeva requested review from storage-core-developers 2024-07-26 10:30:15 +00:00
Owner

Please, remove the formatting changes, if possible.
It seems we are going in rounds, need a task for this, to store the configuration in this repo.
93aaec4e0d
e92ce668a8

Please, remove the formatting changes, if possible. It seems we are going in rounds, need a task for this, to store the configuration in this repo. 93aaec4e0d741c12a1c91f50ac810c2008ba6e02 e92ce668a86ac3c84cf7ffb97faf557c95ab0663
elebedeva force-pushed fix/delet-preset-data from 5f20d5d88a to 4ec75a1c89 2024-07-26 13:21:57 +00:00 Compare
Author
Member

@fyrchik
Removed commit with formatting changes.

@fyrchik Removed commit with formatting changes.
fyrchik reviewed 2024-07-26 13:31:14 +00:00
@ -212,3 +222,3 @@
}
const resp = grpc_client.delete(obj.c_id, obj.o_id);
const obj = obj_list[Math.floor(Math.random() * obj_list.length)];
Owner

It makes sense for read, because we can read each object multiple times.
But we cannot delete it multiple times (probably can, but the result would be meaningless).

It makes sense for read, because we can read each object multiple times. But we cannot delete it multiple times (probably can, but the result would be meaningless).

Please, remove the formatting changes, if possible.
It seems we are going in rounds, need a task for this, to store the configuration in this repo.
93aaec4e0d
e92ce668a8

CI/CD formatter will be better:)

> Please, remove the formatting changes, if possible. > It seems we are going in rounds, need a task for this, to store the configuration in this repo. > 93aaec4e0d741c12a1c91f50ac810c2008ba6e02 > e92ce668a86ac3c84cf7ffb97faf557c95ab0663 CI/CD formatter will be better:)
Owner

CI/CD formatter will be better:)

Exactly, that is the task we need.

>CI/CD formatter will be better:) Exactly, that is the task we need.
elebedeva closed this pull request 2024-08-09 08:48:42 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 56s
Tests and linters / Tests (1.22) (pull_request) Successful in 1m28s
Tests and linters / Tests (1.21) (pull_request) Successful in 1m35s
Tests and linters / Lint (pull_request) Successful in 1m55s
Tests and linters / Tests with -race (pull_request) Successful in 2m10s

Pull request closed

Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#157
No description provided.