TrueCloudLab/xk6-frostfs
40
0
Fork 19
Code Issues 36 Pull requests 2 Releases Activity Actions

s3: Allow to specify directory height and width #174

Merged
fyrchik merged 1 commit from dstepanov-yadro/xk6-frostfs:feat/s3_object_dirs into master 2024-10-25 10:31:11 +00:00
Conversation 0 Commits 1 Files changed 7 +28 -10
dstepanov-yadro commented 2024-10-23 14:16:55 +00:00
Member
Copy link

Closes #124

Closes #124
dstepanov-yadro added 1 commit 2024-10-23 14:16:56 +00:00
[#173] s3: Allow to specify directory height and width
All checks were successful
DCO action / DCO (pull_request) Successful in 37s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m54s
Details
Tests and linters / Tests (pull_request) Successful in 2m7s
Details
Tests and linters / Lint (pull_request) Successful in 3m31s
Details
6080908613 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro requested review from performance-committers 2024-10-23 14:17:35 +00:00
dstepanov-yadro force-pushed feat/s3_object_dirs from 6080908613 to 9d5292df87 2024-10-23 19:04:51 +00:00 Compare
fyrchik reviewed 2024-10-24 06:23:10 +00:00
scenarios/s3local.js Outdated
@ -132,3 +132,3 @@
export function obj_write() {
const key = __ENV.OBJ_NAME || uuidv4();
let width = parseInt(__ENV.DIR_WIDTH || '0');
fyrchik commented 2024-10-24 06:23:10 +00:00
Owner
Copy link

How about moving it to a helper file in scenarios/libs? See scenarios/libs/env-parser.js as an example we use.
It should improve maintainability.

How about moving it to a helper file in `scenarios/libs`? See `scenarios/libs/env-parser.js` as an example we use. It should improve maintainability.
fyrchik approved these changes 2024-10-24 06:23:14 +00:00
Dismissed
dstepanov-yadro force-pushed feat/s3_object_dirs from 9d5292df87 to 78bb8bdf9a 2024-10-24 13:30:44 +00:00 Compare
dstepanov-yadro dismissed fyrchik's review 2024-10-24 13:30:44 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant approved these changes 2024-10-24 13:32:52 +00:00
Dismissed
dstepanov-yadro force-pushed feat/s3_object_dirs from 78bb8bdf9a to e0cbc3b763 2024-10-25 09:20:34 +00:00 Compare
dstepanov-yadro dismissed acid-ant's review 2024-10-25 09:20:35 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant approved these changes 2024-10-25 09:27:42 +00:00
fyrchik approved these changes 2024-10-25 10:31:06 +00:00
fyrchik merged commit e0cbc3b763 into master 2024-10-25 10:31:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/performance-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#174
No description provided.
Delete branch "dstepanov-yadro/xk6-frostfs:feat/s3_object_dirs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?