TrueCloudLab/xk6-frostfs
43
1
Fork 20
Code Issues 35 Pull requests 2 Releases Activity Actions

s3: Support variable key length #175

Merged
fyrchik merged 1 commit from dstepanov-yadro/xk6-frostfs:feat/s3_key_lenght into master 2024-11-02 14:21:48 +00:00
Conversation 3 Commits 1 Files changed 1 +1
dstepanov-yadro commented 2024-10-28 09:31:04 +00:00
Member
Copy link

Closes #173

Closes #173
dstepanov-yadro added 1 commit 2024-10-28 09:31:05 +00:00
[#173] s3: Support variable key length
All checks were successful
DCO action / DCO (pull_request) Successful in 1m2s
Details
Tests and linters / Tests (pull_request) Successful in 1m43s
Details
Tests and linters / Lint (pull_request) Successful in 2m42s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m43s
Details
f4c65c6112 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro reviewed 2024-10-28 09:31:43 +00:00
scenarios/libs/keygen.js Outdated
@ -1,17 +1,30 @@
import {uuidv4} from './k6-utils-1.4.0.js';
import { uuidv4 } from './k6-utils-1.4.0.js';
dstepanov-yadro commented 2024-10-28 09:31:43 +00:00
Author
Member
Copy link

Excuse me, please, but can I not make a separate commit for format fix?

Excuse me, please, but can I not make a separate commit for format fix?
fyrchik commented 2024-10-28 12:08:08 +00:00
Owner
Copy link

How come it is different? You have added this file in the last PR.

How come it is different? _You_ have added this file in the last PR.
dstepanov-yadro commented 2024-10-28 15:57:10 +00:00
Author
Member
Copy link

But I haven't performed format :-(

But I haven't performed format :-(
dstepanov-yadro force-pushed feat/s3_key_lenght from f4c65c6112 to 44f08db0a5 2024-10-28 09:34:22 +00:00 Compare
fyrchik approved these changes 2024-10-28 12:10:10 +00:00
Dismissed
scenarios/libs/keygen.js Outdated
@ -17,0 +16,4 @@
return key;
}
const asciiLetters = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890()"
fyrchik commented 2024-10-28 12:08:52 +00:00
Owner
Copy link

Do we really need brackets?

Do we really need brackets?
dstepanov-yadro commented 2024-10-28 13:32:12 +00:00
Author
Member
Copy link

Why not?

Why not?
fyrchik commented 2024-10-28 15:49:53 +00:00
Owner
Copy link

Cuz they look strange.

Cuz they look strange.
dstepanov-yadro commented 2024-10-28 15:58:32 +00:00
Author
Member
Copy link

Ok, dropped strange brackets

Ok, dropped strange brackets
fyrchik dismissed fyrchik's review 2024-10-28 12:10:38 +00:00
Reason:

misclick

fyrchik commented 2024-10-28 12:12:12 +00:00
Owner
Copy link

To be clear, this PR adds support for arbitrary but constant length.
I am not sure what we wanted in the first place in that task? @anikeev-yadro
Another option is that the length is random too, so we have keys of lengths e.g. 3 to 10 in a single scenario.

Other that this, LGTM

To be clear, this PR adds support for arbitrary but constant length. I am not sure what we wanted in the first place in that task? @anikeev-yadro Another option is that the length is random too, so we have keys of lengths e.g. 3 to 10 in a single scenario. Other that this, LGTM
anikeev-yadro commented 2024-10-28 12:19:29 +00:00
Member
Copy link

I wanted it a little differently. Here is a more detailed description #173 (comment)
How can I run k6 with keys of different lengths in one run?

I wanted it a little differently. Here is a more detailed description https://git.frostfs.info/TrueCloudLab/xk6-frostfs/issues/173#issuecomment-54679 How can I run k6 with keys of different lengths in one run?
dstepanov-yadro commented 2024-10-28 13:01:47 +00:00
Author
Member
Copy link

I wanted it a little differently. Here is a more detailed description #173 (comment)
How can I run k6 with keys of different lengths in one run?

You can run many k6 runs in parallel.

k6 is load test util, but looks like you try to use it for functional tests.

> I wanted it a little differently. Here is a more detailed description https://git.frostfs.info/TrueCloudLab/xk6-frostfs/issues/173#issuecomment-54679 > How can I run k6 with keys of different lengths in one run? You can run many k6 runs in parallel. k6 is **load** test util, but looks like you try to use it for functional tests.
dstepanov-yadro changed title from WIP: s3: Support variable key length to s3: Support variable key length 2024-10-28 15:31:03 +00:00
dstepanov-yadro requested review from performance-committers 2024-10-28 15:56:32 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-10-28 15:56:38 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-10-28 15:56:38 +00:00
dstepanov-yadro force-pushed feat/s3_key_lenght from 44f08db0a5 to 1c7a3b3b6c 2024-10-28 15:58:12 +00:00 Compare
dstepanov-yadro added 1 commit 2024-10-28 16:07:21 +00:00
[#173] s3: Fix missing import
All checks were successful
DCO action / DCO (pull_request) Successful in 1m5s
Details
Tests and linters / Tests (pull_request) Successful in 1m45s
Details
Tests and linters / Lint (pull_request) Successful in 2m45s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m44s
Details
f5df03c718 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro reviewed 2024-10-28 16:08:29 +00:00
scenarios/s3.js
@ -9,6 +9,7 @@ import stats from 'k6/x/frostfs/stats';
import {generateS3Key} from './libs/keygen.js';
import {parseEnv} from './libs/env-parser.js';
import {textSummary} from './libs/k6-summary-0.0.2.js';
import {newGenerator} from './libs/datagen.js';
dstepanov-yadro commented 2024-10-28 16:08:29 +00:00
Author
Member
Copy link

From #174/files

From https://git.frostfs.info/TrueCloudLab/xk6-frostfs/pulls/174/files
acid-ant approved these changes 2024-10-29 05:52:32 +00:00
aarifullin approved these changes 2024-10-29 14:16:10 +00:00
fyrchik merged commit f5df03c718 into master 2024-10-29 14:46:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
TrueCloudLab/performance-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#175
No description provided.
Delete branch "dstepanov-yadro/xk6-frostfs:feat/s3_key_lenght"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?