TrueCloudLab/xk6-frostfs
43
1
Fork 20
Code Issues 35 Pull requests 2 Releases Activity Actions

preset_grpc: Remove deprecated parameter acl #182

Merged
fyrchik merged 2 commits from acid-ant/xk6-frostfs:bugfix/replace-acl-ape into master 2024-11-20 15:43:59 +00:00
Conversation 2 Commits 2 Files changed 5 +28 -21
acid-ant commented 2024-11-14 12:36:06 +00:00
Member
Copy link

Close #180.

Add new parameter rule to have ability to add rule to created container.
Example of usage:

./scenarios/preset/preset_grpc.py --size 800 --containers 4 --out /home/annikifa/workspace/xk6-frostfs/grpc.json \
    --endpoint s01.frostfs.devenv:8080 \
    --preload_obj 3 \
    --policy "REP 1 IN X CBF 1 SELECT 4 FROM * AS X" \
    --rule "allow Container.* *" \
    --rule "allow Object.* *" \
    --config ../frostfs-dev-env/cfg.yml --wallet ../frostfs-dev-env/wallets/wallet.json

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #180. Add new parameter `rule` to have ability to add rule to created container. Example of usage: ``` ./scenarios/preset/preset_grpc.py --size 800 --containers 4 --out /home/annikifa/workspace/xk6-frostfs/grpc.json \ --endpoint s01.frostfs.devenv:8080 \ --preload_obj 3 \ --policy "REP 1 IN X CBF 1 SELECT 4 FROM * AS X" \ --rule "allow Container.* *" \ --rule "allow Object.* *" \ --config ../frostfs-dev-env/cfg.yml --wallet ../frostfs-dev-env/wallets/wallet.json ``` Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant added 1 commit 2024-11-14 12:36:06 +00:00
[#180] preset_grpc: Remove deprecated parameter acl
All checks were successful
DCO action / DCO (pull_request) Successful in 1m10s
Details
Tests and linters / Tests (pull_request) Successful in 1m54s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m32s
Details
Tests and linters / Lint (pull_request) Successful in 2m59s
Details
f0cbf9c301 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2024-11-14 12:36:20 +00:00
acid-ant requested review from storage-core-developers 2024-11-14 12:36:21 +00:00
acid-ant requested review from qa-committers 2024-11-14 12:36:53 +00:00
acid-ant requested review from qa-developers 2024-11-14 12:36:56 +00:00
anikeev-yadro commented 2024-11-14 14:10:10 +00:00
Member
Copy link

in issue #180 we need not only remove parameter. We need to set APE chains after create conatiners in preset.

in issue https://git.frostfs.info/TrueCloudLab/xk6-frostfs/issues/180 we need not only remove parameter. We `need to set APE chains after create conatiners in preset.`
acid-ant added 1 commit 2024-11-15 08:13:49 +00:00
[#180] preset_grpc: Add ability to attach rule for created container
All checks were successful
DCO action / DCO (pull_request) Successful in 1m9s
Details
Tests and linters / Tests (pull_request) Successful in 1m51s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m27s
Details
Tests and linters / Lint (pull_request) Successful in 3m4s
Details
ebea190737 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
elebedeva approved these changes 2024-11-15 09:10:00 +00:00
Dismissed
anikeev-yadro approved these changes 2024-11-15 09:40:59 +00:00
Dismissed
fyrchik reviewed 2024-11-15 10:36:13 +00:00
scenarios/preset/helpers/frostfs_cli.py Outdated
@ -39,0 +38,4 @@
if rules:
r = ""
for rule in rules:
rule = rule.replace("CONTAINER_ID", cid)
fyrchik commented 2024-11-15 10:36:13 +00:00
Owner
Copy link

Please give an example where this replace is actually useful?
This chain is attached to a container, any comparison with CONTAINER_ID will trivially be true or false.

Please give an example where this replace is actually useful? This chain is _attached_ to a container, any comparison with `CONTAINER_ID` will trivially be true or false.
acid-ant commented 2024-11-15 10:55:45 +00:00
Author
Member
Copy link

Right, now I see that it looks redundant.

Right, now I see that it looks redundant.
fyrchik approved these changes 2024-11-15 10:36:37 +00:00
Dismissed
fyrchik left a comment
Owner
Copy link

It would be nice to have some defaults, I would go with a fully public container.

It would be nice to have some defaults, I would go with a fully public container.
fyrchik dismissed fyrchik's review 2024-11-15 10:36:42 +00:00
acid-ant force-pushed bugfix/replace-acl-ape from ebea190737 to 9379ca8fc3 2024-11-15 10:53:56 +00:00 Compare
acid-ant dismissed elebedeva's review 2024-11-15 10:53:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant dismissed anikeev-yadro's review 2024-11-15 10:53:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant force-pushed bugfix/replace-acl-ape from 9379ca8fc3 to 76fd5c9706 2024-11-15 10:55:44 +00:00 Compare
acid-ant commented 2024-11-15 10:56:19 +00:00
Author
Member
Copy link

It would be nice to have some defaults, I would go with a fully public container.

Added default rule allow Object.* *

> It would be nice to have some defaults, I would go with a fully public container. Added default rule `allow Object.* *`
acid-ant requested review from storage-core-committers 2024-11-15 10:56:36 +00:00
acid-ant requested review from storage-core-developers 2024-11-15 10:56:37 +00:00
dstepanov-yadro approved these changes 2024-11-15 13:18:47 +00:00
elebedeva approved these changes 2024-11-15 13:43:57 +00:00
aarifullin approved these changes 2024-11-18 09:00:34 +00:00
fyrchik approved these changes 2024-11-18 10:28:38 +00:00
fyrchik merged commit 76fd5c9706 into master 2024-11-18 10:28:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
elebedeva
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#182
No description provided.
Delete branch "acid-ant/xk6-frostfs:bugfix/replace-acl-ape"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?