TrueCloudLab/xk6-frostfs
42
1
Fork 20
Code Issues 35 Pull requests 2 Releases Activity Actions

WIP: Add CODEOWNERS #184

Closed
potyarkin wants to merge 1 commit from potyarkin/xk6-frostfs:feature/add-codeowners into master
pull from: potyarkin/xk6-frostfs:feature/add-codeowners
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +3
potyarkin commented 2024-12-10 15:42:15 +00:00
Member
Copy link

CODEOWNERS file specifies reviewers which will be automatically added to each PR.

Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools:

  • Filepaths are matched using Golang regex library instead of simple fileglobs
  • All matching lines are active instead of only the first one
  • There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name)

This PR is a part of multirepo cleanup effort: TrueCloudLab/frostfs-infra#90

CODEOWNERS file specifies reviewers which will be automatically added to each PR. Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools: - Filepaths are matched using Golang regex library instead of simple fileglobs - All matching lines are active instead of only the first one - There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name) This PR is a part of multirepo cleanup effort: https://git.frostfs.info/TrueCloudLab/frostfs-infra/issues/90
potyarkin added 1 commit 2024-12-10 15:42:15 +00:00
[#] Add CODEOWNERS
Some checks failed
DCO action / DCO (pull_request) Failing after 2m2s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m6s
Details
Tests and linters / Tests (pull_request) Successful in 6m26s
Details
Tests and linters / Lint (pull_request) Successful in 7m50s
Details
2da1a405fd 
Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>
potyarkin force-pushed feature/add-codeowners from 2da1a405fd to 72a3d3b833 2024-12-10 15:58:43 +00:00 Compare
potyarkin changed title from WIP: Add CODEOWNERS to Add CODEOWNERS 2024-12-10 15:58:54 +00:00
potyarkin changed title from Add CODEOWNERS to WIP: Add CODEOWNERS 2024-12-10 15:59:07 +00:00
potyarkin closed this pull request 2024-12-10 15:59:51 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 2m33s
Details
Tests and linters / Lint (pull_request) Successful in 4m6s
Details
Tests and linters / Tests (pull_request) Successful in 6m40s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m44s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#184
No description provided.
Delete branch "potyarkin/xk6-frostfs:feature/add-codeowners"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?