TrueCloudLab/xk6-frostfs
42
1
Fork 20
Code Issues 33 Pull requests 2 Releases Activity Actions

Support AWS Profiles and fix examples #186

Open
alexvanin wants to merge 2 commits from alexvanin/xk6-frostfs:feature/181 into master
pull from: alexvanin/xk6-frostfs:feature/181
merge into: TrueCloudLab:master
Conversation 0 Commits 2 Files changed 7 +20 -8
alexvanin commented 2024-12-28 12:13:39 +00:00
Owner
Copy link

This PR introduces two changes:

  1. Closes #181 by adding new s3 client parameter to pick AWS profile. This is useful when client has multiple AWS credentials set by aws configure --profile <profile-name>
  2. Fixes examples after #114 when datagen.Payload type was introduced.
This PR introduces two changes: 1) Closes #181 by adding new s3 client parameter to pick AWS profile. This is useful when client has multiple AWS credentials set by `aws configure --profile <profile-name>` 2) Fixes examples after #114 when datagen.Payload type was introduced.
alexvanin self-assigned this 2024-12-28 12:13:39 +00:00
alexvanin added 2 commits 2024-12-28 12:13:40 +00:00 
Signed-off-by: Alex Vanin <a.vanin@yadro.com>
[#114] Fix examples
All checks were successful
DCO action / DCO (pull_request) Successful in 27s
Details
Tests and linters / Tests (pull_request) Successful in 1m37s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m53s
Details
Tests and linters / Lint (pull_request) Successful in 2m53s
Details
3c6023ca29 
With #114, upload data functions now works with
datagen payload only, thus examples has to be updated.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
alexvanin requested review from storage-core-committers 2024-12-28 12:13:40 +00:00
alexvanin requested review from storage-core-developers 2024-12-28 12:13:40 +00:00
alexvanin requested review from storage-services-committers 2024-12-28 12:13:40 +00:00
alexvanin requested review from storage-services-developers 2024-12-28 12:13:40 +00:00
fyrchik approved these changes 2024-12-28 12:28:31 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 27s
Details
Tests and linters / Tests (pull_request) Successful in 1m37s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m53s
Details
Tests and linters / Lint (pull_request) Successful in 2m53s
Details
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/181:alexvanin-feature/181
git checkout alexvanin-feature/181
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
alexvanin
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#186
No description provided.
Delete branch "alexvanin/xk6-frostfs:feature/181"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?