Check NOFILE limit before creating local storage engine #55

ale64bit · 2023-04-21T11:02:34Z

ale64bit commented

2023-04-21 11:02:34 +00:00

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Close #54

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Close #54

ale64bit added 1 commit 2023-04-21 11:02:35 +00:00

Check NOFILE limit before creating local storage engine 81b7d3f536

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>

ale64bit requested review from storage-core-committers 2023-04-21 11:02:52 +00:00

ale64bit requested review from storage-core-developers 2023-04-21 11:02:52 +00:00

acid-ant approved these changes 2023-04-24 07:25:22 +00:00

fyrchik reviewed 2023-04-25 10:17:18 +00:00

internal/local/local.go

					
				@ -80,0 +86,4 @@

				// necessarily the service user, for which the limits are preconfigured correctly.

				//

				// See: https://k6.io/docs/misc/fine-tuning-os/

				func checkResourceLimits() error {

fyrchik commented

2023-04-25 10:17:18 +00:00

What will happen on windows? Not that we use it, but worth mentioning in the docs.

ale64bit commented

2023-04-25 11:17:41 +00:00

On Windows it won't even compile and this is WAI. We have many nix-specific dependencies all over the place (implicit and explicit ones).

👍 1

fyrchik approved these changes 2023-04-25 10:17:24 +00:00

fyrchik merged commit 81b7d3f536 into master

2023-04-25 14:38:28 +00:00

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#55