TrueCloudLab/xk6-frostfs
40
0
Fork 18
Code Issues 37 Pull requests 1 Releases Activity Actions

Allow to split objects on client #75

Merged
fyrchik merged 1 commit from acid-ant/xk6-frostfs:feature/72-cut-obj-in-client into master 2023-07-26 21:08:03 +00:00
Conversation 0 Commits 1 Files changed 8 +57 -30
acid-ant commented 2023-06-27 06:54:49 +00:00
Member
Copy link

Close #72

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Usage examples:

$ rm -f grpc.json && ./scenarios/preset/preset_grpc.py --size 1024 ... --prepare-locally=True
$
$ ./k6 run -e DURATION=20 -e WRITE_OBJ_SIZE=8192 ... -e PREPARE_LOCALLY=true
Close #72 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com> Usage examples: ``` $ rm -f grpc.json && ./scenarios/preset/preset_grpc.py --size 1024 ... --prepare-locally=True $ $ ./k6 run -e DURATION=20 -e WRITE_OBJ_SIZE=8192 ... -e PREPARE_LOCALLY=true ```
acid-ant force-pushed feature/72-cut-obj-in-client from 72da79ffc2 to 4726f23dfa 2023-06-28 19:38:01 +00:00 Compare
acid-ant force-pushed feature/72-cut-obj-in-client from 4726f23dfa to a2d9e1ce55 2023-07-06 05:32:54 +00:00 Compare
acid-ant force-pushed feature/72-cut-obj-in-client from a2d9e1ce55 to ee0f8eeb12 2023-07-06 06:27:57 +00:00 Compare
acid-ant force-pushed feature/72-cut-obj-in-client from ee0f8eeb12 to 0bfbbe5d7e 2023-07-06 06:45:53 +00:00 Compare
acid-ant changed title from WIP: Allow to split objects on client to Allow to split objects on client 2023-07-06 06:46:58 +00:00
acid-ant requested review from anikeev-yadro 2023-07-06 06:47:13 +00:00
acid-ant requested review from abereziny 2023-07-06 06:47:13 +00:00
acid-ant requested review from storage-core-committers 2023-07-06 06:47:13 +00:00
acid-ant requested review from storage-core-developers 2023-07-06 06:47:13 +00:00
acid-ant force-pushed feature/72-cut-obj-in-client from 0bfbbe5d7e to 2f9b35a146 2023-07-06 09:24:41 +00:00 Compare
dstepanov-yadro reviewed 2023-07-06 14:21:36 +00:00
scenarios/preset/preset_grpc.py Outdated
@ -36,6 +36,8 @@ parser.add_argument('--ignore-errors', help='Ignore preset errors')
parser.add_argument('--workers', help='Count of workers in preset. Max = 50, Default = 50', default=50)
parser.add_argument('--sleep', help='Time to sleep between container creation and object PUT (in seconds), '
'Default = 8', default=8)
parser.add_argument('--prepare-locally', help='Generate object header on the client side (for big object - '
dstepanov-yadro commented 2023-07-06 14:21:36 +00:00
Member
Copy link

I don't think it is required for preset.

I don't think it is required for preset.
👍 1
acid-ant commented 2023-07-07 07:05:13 +00:00
Author
Member
Copy link

As discussed option was removed, but I prefer to keep ability to use this option in future(currently flag set to False).

As discussed option was removed, but I prefer to keep ability to use this option in future(currently flag set to `False`).
fyrchik commented 2023-07-07 09:31:55 +00:00
Owner
Copy link

If we have no option, what is the motivation for having the code?
It wouldn't be hard to add it in future, but now we need to support it.

If we have no option, what is the motivation for having the code? It wouldn't be hard to add it in future, but now we need to support it.
acid-ant commented 2023-07-07 10:02:01 +00:00
Author
Member
Copy link

The idea is to test it, and, if we will find it useful, enable by default.

The idea is to test it, and, if we will find it useful, enable by default.
acid-ant commented 2023-07-07 10:13:30 +00:00
Author
Member
Copy link

Removed from preset.

Removed from `preset`.
dstepanov-yadro approved these changes 2023-07-06 14:21:49 +00:00
acid-ant force-pushed feature/72-cut-obj-in-client from 2f9b35a146 to 74fa95e665 2023-07-07 07:03:32 +00:00 Compare
acid-ant force-pushed feature/72-cut-obj-in-client from 74fa95e665 to 4cbd7c9c70 2023-07-07 10:13:03 +00:00 Compare
acid-ant force-pushed feature/72-cut-obj-in-client from 4cbd7c9c70 to ff6814e15d 2023-07-07 10:17:12 +00:00 Compare
fyrchik approved these changes 2023-07-10 15:03:06 +00:00
fyrchik merged commit ff6814e15d into master 2023-07-11 14:08:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
anikeev-yadro
abereziny
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/xk6-frostfs#75
No description provided.
Delete branch "acid-ant/xk6-frostfs:feature/72-cut-obj-in-client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?