Improve logging for preset #92

abereziny · 2023-08-08T15:58:30Z

abereziny commented

2023-08-08 15:58:30 +00:00

Closes #91
Signed-off-by: Andrey Berezin a.berezin@yadro.com

Closes #91 Signed-off-by: Andrey Berezin <a.berezin@yadro.com>

abereziny added 1 commit 2023-08-08 15:58:32 +00:00

86f5dfa47a [#91 ] Improve logging for preset

Signed-off-by: Andrey Berezin <a.berezin@yadro.com>

abereziny requested review from storage-services-developers 2023-08-08 15:58:38 +00:00

abereziny requested review from storage-services-committers 2023-08-08 15:58:39 +00:00

abereziny requested review from storage-core-developers 2023-08-08 15:58:39 +00:00

abereziny requested review from storage-core-committers 2023-08-08 15:58:39 +00:00

fyrchik reviewed 2023-08-08 16:00:24 +00:00

scenarios/preset/helpers/aws_cli.py

													
				@ -41,3 +43,3 @@

				    if not success:

				        print(f" > Object {object_name} has not been uploaded.")

				        log(f"{cmd_line}\n"

fyrchik commented

2023-08-08 16:00:24 +00:00

Python has some native logging capabilities https://docs.python.org/3/library/logging.html#logging.info , don't we want to use them?

abereziny commented

2023-08-16 08:13:34 +00:00

Poster

We want specific prefix (date, endpoint) to each message so we use custom function.

fyrchik commented

2023-08-16 08:24:56 +00:00

We use endpoint=... syntax in scenarios
Anyway it seems logging can be customized as you wish https://docs.python.org/3/library/logging.html#logging.Formatter

I will create a separate task for this then.

1. We use `endpoint=...` syntax in scenarios 2. Anyway it seems logging can be customized as you wish https://docs.python.org/3/library/logging.html#logging.Formatter I will create a separate task for this then.