TrueCloudLab/zapjournald
22
0
Fork 5
Code Issues 6 Pull requests 2 Releases Activity

Add small test for getFieldValue function #8

Merged
AlekseySVTN merged 1 commit from AlekseySVTN/zapjournald:feature/7-add_small_test_for_getFieldValue_function into master 2023-07-26 21:08:06 +00:00
Conversation 2 Commits 1 Files changed 1 +2 -2
AlekseySVTN commented 2023-04-12 09:52:50 +00:00
Member
Copy link

[#7] Add small test for getFieldValue function
[#7] Fix comment lexical (by the comment of Vladimir Domnich TrueCloudLab/zapjournald#3)

[#7] Add small test for getFieldValue function [#7] Fix comment lexical (by the comment of Vladimir Domnich TrueCloudLab/zapjournald#3)
requested reviews from alexvanin, vdomnich-yadro, dstepanov-yadro, dkirillov, ironbee, fyrchik 2023-04-12 09:54:03 +00:00
AlekseySVTN changed title from feature/7-add_small_test_for_getFieldValue_function to Add small test for getFieldValue function 2023-04-12 10:07:09 +00:00
dstepanov-yadro reviewed 2023-04-12 13:12:17 +00:00
zapjournald_test.go Outdated
@ -0,0 +31,4 @@
{"Complex128", zap.Complex128("k", 1+2i), "(1+2i)"},
{"Complex64", zap.Complex64("k", 1+2i), "(1+2i)"},
{"Duration", zap.Duration("k", 1), "1"},
{"Float64", zap.Float64("k", 3.14), "4614253070214989087"},
dstepanov-yadro commented 2023-04-12 13:12:13 +00:00
Member
Copy link

What does it mean? Why 3.14 = 4614253070214989087 ?

What does it mean? Why 3.14 = 4614253070214989087 ?
AlekseySVTN commented 2023-04-13 06:16:59 +00:00
Author
Member
Copy link

It is because zap use int64(math.Float64bits(val)) in zap.Float64() function, and the same logic in Float32() function.
845ca51d5b/field.go (L138)

It is because zap use ```int64(math.Float64bits(val))``` in zap.Float64() function, and the same logic in Float32() function. https://github.com/uber-go/zap/blob/845ca51d5b8d9fed9fe14f35ab13b6b160d5762d/field.go#L138
dstepanov-yadro marked this conversation as resolved
vdomnich-yadro approved these changes 2023-04-13 07:40:57 +00:00
vdomnich-yadro left a comment
Member
Copy link

Overall looks good, just few notes/suggestions

Overall looks good, just few notes/suggestions
zapjournald.go Outdated
@ -160,3 +160,3 @@
case zapcore.TimeType:
if f.Interface != nil {
return f.Interface
return fmt.Sprintf("%d %v", f.Integer, f.Interface)
vdomnich-yadro commented 2023-04-13 07:30:19 +00:00
Member
Copy link

May I ask to add a comment that shows example of this transformation?

Probably it can be seen from tests:

{"Time", zap.Time("k", time.Unix(0, 0).In(time.UTC)), "0 UTC"}
{"TimeFull", zap.Time("k", time.Time{}), "0001-01-01 00:00:00 +0000 UTC"}

But having comment next to the code still would be helpful :)

May I ask to add a comment that shows example of this transformation? Probably it can be seen from tests: ``` {"Time", zap.Time("k", time.Unix(0, 0).In(time.UTC)), "0 UTC"} {"TimeFull", zap.Time("k", time.Time{}), "0001-01-01 00:00:00 +0000 UTC"} ``` But having comment next to the code still would be helpful :)
AlekseySVTN commented 2023-04-13 07:53:27 +00:00
Author
Member
Copy link

Yes, of course, it will be perfect. :)

Yes, of course, it will be perfect. :)
AlekseySVTN commented 2023-04-13 07:58:26 +00:00
Author
Member
Copy link

fixed

fixed
vdomnich-yadro marked this conversation as resolved
zapjournald_test.go Outdated
@ -0,0 +55,4 @@
}
for _, tt := range tests {
fieldValue := valueToString(getFieldValue(tt.field))
vdomnich-yadro commented 2023-04-13 07:39:30 +00:00
Member
Copy link

Instead of single test with multiple results I recommend:

for _, test := range tests {
	t.Run(test.name, func(t *testing.T) {
    	// do my testing stuff
	})
}

It allows to see individual test results rather than pass/failure of single huge test.

Instead of single test with multiple results I recommend: ``` for _, test := range tests { t.Run(test.name, func(t *testing.T) { // do my testing stuff }) } ``` It allows to see individual test results rather than pass/failure of single huge test.
AlekseySVTN commented 2023-04-13 07:53:51 +00:00
Author
Member
Copy link

Yes, I am fully agree with you.

Yes, I am fully agree with you.
AlekseySVTN commented 2023-04-13 07:58:36 +00:00
Author
Member
Copy link

fixed

fixed
vdomnich-yadro marked this conversation as resolved
zapjournald_test.go Outdated
@ -0,0 +70,4 @@
return nil
}
// usernameTestExample type, which are implements ArrayMarshaller interface.
vdomnich-yadro commented 2023-04-13 07:40:43 +00:00
Member
Copy link

Probably comment is from other type.

Probably comment is from other type.
AlekseySVTN commented 2023-04-13 07:45:53 +00:00
Author
Member
Copy link

Yes, thank you.

Yes, thank you.
AlekseySVTN commented 2023-04-13 07:58:43 +00:00
Author
Member
Copy link

fixed

fixed
vdomnich-yadro marked this conversation as resolved
dstepanov-yadro approved these changes 2023-04-13 07:57:49 +00:00
AlekseySVTN force-pushed feature/7-add_small_test_for_getFieldValue_function from 71bea0a62f to 2927ca8e3d 2023-04-13 07:58:24 +00:00 Compare
requested review from vdomnich-yadro 2023-04-13 07:59:30 +00:00
vdomnich-yadro approved these changes 2023-04-13 08:14:04 +00:00
dkirillov reviewed 2023-04-13 09:22:35 +00:00
zapjournald_test.go Outdated
@ -0,0 +6,4 @@
"testing"
"time"
"github.com/stretchr/testify/assert"
dkirillov commented 2023-04-13 09:22:35 +00:00
Member
Copy link

Can we group all non standard package together?

Can we group all non standard package together?
AlekseySVTN commented 2023-04-13 10:09:28 +00:00
Author
Member
Copy link

Yes, thank you.
Fixed.

Yes, thank you. Fixed.
AlekseySVTN force-pushed feature/7-add_small_test_for_getFieldValue_function from 2927ca8e3d to e27cc2ec1e 2023-04-13 10:09:08 +00:00 Compare
acid-ant commented 2023-04-13 11:18:42 +00:00
Member
Copy link

@AlekseySVTN you are committing code as an individual developer?
Signed-off-by: Aleksey Savaitan <zxc_off@mail.ru>

@AlekseySVTN you are committing code as an individual developer? `Signed-off-by: Aleksey Savaitan <zxc_off@mail.ru>`
👍 1
AlekseySVTN force-pushed feature/7-add_small_test_for_getFieldValue_function from e27cc2ec1e to 4c6e1f7365 2023-04-14 08:01:07 +00:00 Compare
AlekseySVTN commented 2023-04-14 08:04:26 +00:00
Author
Member
Copy link

@acid-ant , after small discussion with Stanislav Bogatyrev, we decided to change sign-off in these commits. Please, check update.

@acid-ant , after small discussion with Stanislav Bogatyrev, we decided to change sign-off in these commits. Please, check update.
acid-ant approved these changes 2023-04-14 12:09:11 +00:00
AlekseySVTN merged commit 4c6e1f7365 into master 2023-04-14 12:48:06 +00:00
AlekseySVTN deleted branch feature/7-add_small_test_for_getFieldValue_function 2023-04-14 12:48:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
dkirillov
ironbee
fyrchik
dstepanov-yadro
vdomnich-yadro
acid-ant
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/zapjournald#8
No description provided.
Delete branch "AlekseySVTN/zapjournald:feature/7-add_small_test_for_getFieldValue_function"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?