Web3N3/runchain
8
0
Fork 1
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add runner contract #1

Open
d.zverev wants to merge 1 commit from d.zverev/runchain:runner into master
pull from: d.zverev/runchain:runner
merge into: Web3N3:master
Conversation 0 Commits 1 Files changed 4 +74
d.zverev commented 2024-09-22 06:48:54 +00:00
Owner
Copy link

Add runner contract.

Add runner contract.
d.zverev added 1 commit 2024-09-22 06:48:54 +00:00
d.zverev requested review from realloc 2024-09-22 13:06:55 +00:00
realloc requested review from dkirillov 2024-09-23 05:50:12 +00:00
realloc requested review from vdomnich-yadro 2024-09-23 05:50:13 +00:00
dkirillov reviewed 2024-09-26 13:04:40 +00:00
dkirillov left a comment
Owner
Copy link

Please fix commit message to link to #1 and add sign-off

Please fix commit message to link to #1 and add sign-off
runnner/go.mod
@ -0,0 +1,5 @@
module runner
dkirillov commented 2024-09-26 12:59:51 +00:00
Owner
Copy link

Should go.mod be in runner directory?

Should `go.mod` be in `runner` directory?
runnner/runner.go
@ -0,0 +27,4 @@
controlPoints: make([]ControlPoint, 0),
}
storage.Put(ctx, runnerName, std.Serialize(runner))
dkirillov commented 2024-09-26 13:03:10 +00:00
Owner
Copy link

It's better to use some prefix for runner names

It's better to use some prefix for runner names
runnner/runner.go
@ -0,0 +52,4 @@
storage.Put(ctx, runnerName, std.Serialize(runner))
}
func Get(runnerName string) Runner {
dkirillov commented 2024-09-26 13:03:34 +00:00
Owner
Copy link

It's better to add this method to safe section in config

It's better to add this method to safe section in config
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u runner:d.zverev-runner
git checkout d.zverev-runner

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master
git merge --no-ff d.zverev-runner
git checkout d.zverev-runner
git rebase master
git checkout master
git merge --ff-only d.zverev-runner
git checkout d.zverev-runner
git rebase master
git checkout master
git merge --no-ff d.zverev-runner
git checkout master
git merge --squash d.zverev-runner
git checkout master
git merge --ff-only d.zverev-runner
git checkout master
git merge d.zverev-runner
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
realloc
dkirillov
vdomnich-yadro
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Web3N3/runchain#1
No description provided.
Delete branch "d.zverev/runchain:runner"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?