aarifullin/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity
6298 commits 35 branches 134 tags 34 MiB
Commit graph

6298 commits

This branch
This branch
All branches
Author SHA1 Message Date
Anna Shaleva
f1fbd6ad4b scripts: update dependency-updator script 
Include Oracle contract to the list of contracts to be updated.
 2022-09-16 20:33:48 +03:00
Roman Khimov
1f94ebe03d
Merge pull request #2679 from nspcc-dev/nns-upd 
examples: NNS update, part 1
 2022-09-16 17:06:38 +03:00
Anna Shaleva
94852ab7f4 nns: add admin to properties 
See 14f43ba8cf/src/NameService/NameService.cs (L69).
 2022-09-16 12:51:07 +03:00
Anna Shaleva
c03e420355 nns: allow to resolve FQDN 
Port 4041924a75.
 2022-09-16 12:51:07 +03:00
Anna Shaleva
e97467726c nns: allow hyphen in domain names 
Port https://github.com/nspcc-dev/neofs-contract/pull/183.
 2022-09-16 12:51:07 +03:00
Anna Shaleva
ce66610369 nns: adjust maxDomainNameFragmentLength 
Port https://github.com/nspcc-dev/neofs-contract/pull/238.
 2022-09-16 12:51:04 +03:00
Roman Khimov
8ecafaaadf
Merge pull request #2691 from nspcc-dev/sc-builder-len 
smartcontract: add Len to Builder
 2022-09-14 10:36:01 +03:00
Roman Khimov
18ed26194f smartcontract: add Len to Builder 
Which is useful in some cases.
 2022-09-14 10:25:10 +03:00
Roman Khimov
bd8d46e11a
Merge pull request #2689 from nspcc-dev/stateroot-shutdown-panic 
stateroot: fix panic on shutdown
 2022-09-13 13:29:57 +03:00
Roman Khimov
5979138306 stateroot: fix panic on shutdown 
Stateroot service is always active, but it might have no wallet.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xc57d41]

goroutine 1 [running]:
github.com/nspcc-dev/neo-go/pkg/wallet.(*Wallet).Close(...)
        github.com/nspcc-dev/neo-go/pkg/wallet/wallet.go:175
github.com/nspcc-dev/neo-go/pkg/services/stateroot.(*service).Shutdown(0xc000105880?)
        github.com/nspcc-dev/neo-go/pkg/services/stateroot/validators.go:77 +0x81
github.com/nspcc-dev/neo-go/pkg/network.(*Server).Shutdown(0xc000105880)
        github.com/nspcc-dev/neo-go/pkg/network/server.go:271 +0x205
github.com/nspcc-dev/neo-go/cli/server.startServer(0xc0002702c0)
        github.com/nspcc-dev/neo-go/cli/server/server.go:641 +0x2675
github.com/urfave/cli.HandleAction({0xe456e0?, 0x1155f20?}, 0x4?)
        github.com/urfave/cli@v1.22.5/app.go:524 +0x50
github.com/urfave/cli.Command.Run({{0xfca38b, 0x4}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xfd6a46, 0x10}, {0xffebe3, ...}, ...}, ...)
        github.com/urfave/cli@v1.22.5/command.go:173 +0x65b
github.com/urfave/cli.(*App).Run(0xc000272000, {0xc00003e180, 0x3, 0x3})
        github.com/urfave/cli@v1.22.5/app.go:277 +0x8a7
main.main()
        ./main.go:21 +0x33
 2022-09-13 13:18:13 +03:00
Roman Khimov
b27e6918bd Makefile: complicate version detection script 
We've declared that we are using semantic versioning. We also want to use `git
describe` to make version strings for us because it's very convenient for
development builds (tagged versions are way simpler). The problem is that the
default `git describe` behavior is not semver compliant. If the most recent
tag is v0.99.2 then it'll generate something like '0.99.2-131-g8dc5b385',
which according to semver is a development version _before_ 0.99.2. While it's
obviously a version _after_ 0.99.2.

That's the one and only reason we have vX.Y.Z-pre tags in our repo. We set
them right after the release according to the release process and that gives
us some '0.99.3-pre-131-g8dc5b385' versions we're all used to. But these tags
are ugly as hell and they clutter up our repo over time.

So there is this idea that we can do patch version increment dynamically.
Making '0.99.2-131-g8dc5b385' be '0.99.3-pre-131-g8dc5b385' without any *-pre
tags. This patch implements this. It's ugly as hell as well, but at least
that's an ugliness somewhere inside our Makefile and not directly visible in
our tags. If we're to do this we can then greatly simplify our release process
(and even allow for CHANGELOG patches to be merged normally).

I know this can be done with awk in somewhat easier way, but no, I'm not into
awk, sorry.
 2022-09-09 17:06:55 +03:00
Roman Khimov
87a4fa827a CHANGELOG: release 0.99.3 2022-09-09 15:33:43 +03:00
Roman Khimov
31792e3132
Merge pull request #2686 from nspcc-dev/drop-at-block-rpcs 
rpcclient: simplify historic API
 2022-09-09 15:18:27 +03:00
Roman Khimov
a1ca28446d
Merge pull request #2683 from nspcc-dev/historic-cli 
Historic calls from CLI
 2022-09-09 15:08:22 +03:00
Roman Khimov
6a5a8c5e89
Merge pull request #2684 from nspcc-dev/build-fix 
Tiny build corrections
 2022-09-09 15:07:51 +03:00
Roman Khimov
d40eb79975 rpcclient: simplify historic API 
util.Uint256 is util.Uint256 and it's same RPC behind the scenes, so we can
make it a bit easier to digest. See #2545 also.
 2022-09-09 13:41:45 +03:00
Roman Khimov
f78a065230 vm/cli: generate Go 1.17 go.mods 2022-09-08 21:18:51 +03:00
Roman Khimov
db36be96b3 README: drop stale Go 1.16 reference 2022-09-08 21:18:02 +03:00
Roman Khimov
29d8d204ef Makefile: always use 8 chars for git revision in version 
That's what we usually have today already, but it's dynamic by default.
 2022-09-08 21:17:08 +03:00
Roman Khimov
d2d190913b cli: add historic abilities for all invoking commands 
Notice that we can't do this for balance commands (unless we change the
interface in some manner) because they use getnepXXbalances.

Fixes #2620.
 2022-09-08 19:20:18 +03:00
Roman Khimov
4403a95ae6 cli: don't return sender from invokeWithArgs 
It's not really needed, deployer knows the sender exactly already.
 2022-09-08 15:57:27 +03:00
Roman Khimov
8dc5b38568
Merge pull request #2681 from nspcc-dev/rpcclient-comments 
RPC client examples, comments and small fixes
 2022-09-08 14:47:31 +03:00
Roman Khimov
541d4b49e1 context: define a constant for transaction context type 2022-09-08 14:33:04 +03:00
Roman Khimov
6be9367f03 rpcclient/notary: add OnNEP17PaymentData and an example 
Update documentation as well to mention it and not mention outdated APIs. We
can't link them yet, this will be done after the release.
 2022-09-08 14:33:04 +03:00
Roman Khimov
4fb4f5a1ac smartcontract: make *util.Uint160 and *util.Uint256 usable for parameters 
Use Any type for NULL.
 2022-09-08 14:33:04 +03:00
Roman Khimov
1e54b422cd emit: make *util.Uint160 and *util.Uint256 emittable 
They can be nil or can be regular uint types we're used to.
 2022-09-08 14:33:04 +03:00
Roman Khimov
3c02177d3c rpcclient: improve comments for some methods 2022-09-08 14:33:04 +03:00
Roman Khimov
3e8e6857e5 rpcclient; deprecate more methods 
They make little sense now.
 2022-09-08 14:33:04 +03:00
Roman Khimov
c4ddf80742 rpcclient: correct Init requirement in documentation 2022-09-08 14:33:04 +03:00
Roman Khimov
ee55e95c28 rpcclient: add examples for nep11/nep17/neo 
GAS doesn't need any, so just mention nep17 package there.
 2022-09-08 14:33:04 +03:00
Roman Khimov
a1c9871d95 nns: it's NEP-11, so make NEP-11 methods available too 2022-09-08 14:33:04 +03:00
Roman Khimov
186e5c19b6 rpcclient: update documentation, mention subpackages 
Drop TODOs (we have relevant GitHub issues), drop verbosity comment (we have
*Verbose APIs for that).
 2022-09-08 14:33:04 +03:00
Roman Khimov
cb1a1f8532 actor: extend documentation, add example 2022-09-08 14:33:04 +03:00
Roman Khimov
e1fe76137e rpcclient: use separate reader/writer structs in nep11 and nep17 
Which greatly simplifies reuse of these packages (and they're expected to be
reused since real tokens implement standards and also add something of their
own) and allows to avoid effects like

  doc_test.go:68:28: ambiguous selector neoContract.BalanceOf

when neo.Contract is used. Avoids duplication in NEP-11 implementation as
well.
 2022-09-08 14:33:03 +03:00
Roman Khimov
00a9376311 invoker: update documentation, add example 2022-09-08 14:33:03 +03:00
Roman Khimov
ea92f3d716 smartcontract: add some notes on API limitations 2022-09-08 13:27:07 +03:00
Roman Khimov
69176168c3 smartcontract: modernize Builder example 
And make it a bit more useful.
 2022-09-07 22:40:25 +03:00
Roman Khimov
aca8ce0d28 unwrap: provide ErrNoSessionID, add some explanations 2022-09-07 22:40:25 +03:00
Roman Khimov
457f904b1b
Merge pull request #2674 from nspcc-dev/update-linter-config 
Update linter config
 2022-09-02 20:17:58 +03:00
Roman Khimov
6c621066a7 circleci: update golangci-lint to current version 2022-09-02 18:36:26 +03:00
Roman Khimov
1895dfb2c1 golangci: enable some more linters 
They have not found anything and maybe we better not have them find anything
in the future. Commented ones can be useful in future, but find too many
problems at the moment.
 2022-09-02 18:36:26 +03:00
Roman Khimov
97193cf337 golangci: add predeclared linter 
These can be confusing.
 2022-09-02 18:36:26 +03:00
Roman Khimov
63f212f4b3 golangci: enable/fix misspell 2022-09-02 18:36:26 +03:00
Roman Khimov
4f3ffe7290 golangci: enable errorlint and fix everything it found 2022-09-02 18:36:23 +03:00
Roman Khimov
c703ac6805 golangci: enable contextcheck linter, fix WSClient 
pkg/rpcclient/wsclient.go:93:30  contextcheck  Function `Dial` should pass the context parameter
 2022-09-02 18:35:54 +03:00
Roman Khimov
3c009271f8 golangci: enable bodyclose checker and fix related code 
It has found an issue in the oracle code, so I think it's worth doing.
 2022-09-02 18:35:54 +03:00
Roman Khimov
df9a4fa7ce golangci: drop deprecated linters 
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
 2022-09-02 18:35:54 +03:00
Roman Khimov
3da8b98fc3
Merge pull request #2672 from nspcc-dev/private-key-cleanup 
Private key cleanup
 2022-09-02 16:20:39 +03:00
Roman Khimov
eb67145f81 keys: check length first, then do things in WIFDecode 
Otherwise we can easily panic there on bad input.
 2022-09-02 14:44:32 +03:00
Roman Khimov
3c722a9498 keys: clean temporary data during key imports 
Don't leak anything this way.
 2022-09-02 14:44:32 +03:00