Airat Arifullin aarifullin
  • Joined on 2023-03-16
aarifullin commented on pull request TrueCloudLab/frostfs-node#235 2023-04-11 15:13:43 +00:00
[#166] node: Parallelize background tree service sync by operation batching

@fyrchik Should we add some comments here? The batching happens implicitly, so...

aarifullin commented on pull request TrueCloudLab/frostfs-node#235 2023-04-11 15:12:40 +00:00
[#166] node: Parallelize background tree service sync by operation batching

I am sure the error check must NOT be ignored here: we'll never figure out if TreeApply is failed in Go

aarifullin created pull request TrueCloudLab/frostfs-node#235 2023-04-11 15:10:26 +00:00
[#166] node: Parallelize background tree service sync by operation batching
aarifullin created branch feature/166-batch_tree_apply in aarifullin/frostfs-node 2023-04-11 15:09:57 +00:00
aarifullin pushed to feature/166-batch_tree_apply at aarifullin/frostfs-node 2023-04-11 15:09:57 +00:00
41b7ef50ad [#166] node: Parallelize background tree service sync by operation batching
aarifullin commented on pull request TrueCloudLab/frostfs-node#135 2023-04-11 11:20:19 +00:00
Tracing for get object

params 3, 4 seems a little bit inconvinient :). 3 is enough (keeping a room for grpc.DialOption doesn't make big profit)

aarifullin commented on pull request TrueCloudLab/frostfs-node#233 2023-04-11 11:08:38 +00:00
[#118] node: add unit concurrent tests for blobstor

There are many ways to check if an object exists. But for me it's more logically correct to check the error from deletion because I check concurrent deletes

aarifullin commented on pull request TrueCloudLab/frostfs-node#224 2023-04-11 11:06:45 +00:00
[#113] cli: add "name" option for "get container" command

It is not necessary to get container

I fixed this but anyway getting the container doesn't seem to burden the iteration :)

aarifullin commented on pull request TrueCloudLab/frostfs-node#224 2023-04-11 11:05:33 +00:00
[#113] cli: add "name" option for "get container" command

Thanks! Forgot to fix after changes. Fixed

aarifullin pushed to feature/113-get_cnr_by_name at aarifullin/frostfs-node 2023-04-11 11:05:08 +00:00
dde9f9d2e4 [#113] cli: add "name" option for "get container" command
aarifullin pushed to feature/113-get_cnr_by_name at aarifullin/frostfs-node 2023-04-11 07:13:50 +00:00
e274b7a612 [#113] cli: add "name" option for "get container" command
aarifullin pushed to feature/113-get_cnr_by_name at aarifullin/frostfs-node 2023-04-10 19:22:49 +00:00
2ad7966284 [#113] cli: add "name" option for "get container" command
aarifullin pushed to feature/113-get_cnr_by_name at aarifullin/frostfs-node 2023-04-10 19:21:24 +00:00
8c6d856958 [#113] cli: add "name" option for "get container" command
aarifullin commented on pull request TrueCloudLab/frostfs-node#224 2023-04-10 19:19:35 +00:00
[#113] cli: add "name" option for "get container" command

I moved this option to list command for comfortable usage for everyone and removed search

aarifullin commented on pull request TrueCloudLab/frostfs-node#224 2023-04-10 19:18:49 +00:00
[#113] cli: add "name" option for "get container" command

Can we check first condition at the beginning of searchContainer() or earlier? Maybe also will be useful to search by the pat of the name?

Glancing at bucket names like `9d6c424a-7a69-4662-836…

aarifullin pushed to feature/113-get_cnr_by_name at aarifullin/frostfs-node 2023-04-10 19:17:02 +00:00
9c384d03c7 [#113] cli: add "name" option for "get container" command