Airat Arifullin aarifullin
  • Joined on 2023-03-16
aarifullin commented on pull request TrueCloudLab/frostfs-node#1579 2024-12-23 13:23:30 +00:00
Fix PutSingle with OID that was already removed

It looks really tricky, but any non-ObjectAlreadyRemoved-error is delegated to chunk processing to not break the Put logic. The alternative way - to introduce a separate bucket for…

aarifullin commented on pull request TrueCloudLab/frostfs-node#1579 2024-12-23 13:11:14 +00:00
Fix PutSingle with OID that was already removed

tombstones are created only for parent for EC objects.

That's why this change has been introduced. ecWriter chunks EC-object and sends these parts down to engine through metabase.…

aarifullin created pull request TrueCloudLab/frostfs-node#1579 2024-12-23 12:03:13 +00:00
Fix PutSingle with OID that was already removed
aarifullin created branch fix/put_single in aarifullin/frostfs-node 2024-12-23 12:01:24 +00:00
aarifullin pushed to fix/put_single at aarifullin/frostfs-node 2024-12-23 12:01:24 +00:00
6347459a39 [#1512] object: Fix put already removed object in EC-container
7c8fa76636 [#1512] object: Make raw PutSingle check status within response
Compare 2 commits »
aarifullin commented on issue TrueCloudLab/frostfs-node#1572 2024-12-19 11:15:06 +00:00
Incorrect APE processing with object attribute condition for DeleteObject

@dkirillov correctly highlighted about local head-ing. It seems this is the only way is to force CheckAPE to fetch a full header. So, the third parameter (that's currently always true)…

aarifullin commented on pull request TrueCloudLab/frostfs-node#1568 2024-12-18 07:52:38 +00:00
Remove "could not"/"can't"/"failed to" from error messages

As we're enhancing error messages, could you, please, also truncate error word from "... error: %w errors in non-cmd package?

aarifullin approved TrueCloudLab/frostfs-node#1453 2024-12-17 13:29:33 +00:00
container: Add ListStream method

Very nice! 👍

aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#305 2024-12-17 11:31:16 +00:00
[#305] tree/pool: Add flag to use net map to prioritize tree services

Okay, it's up to you :)

aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#305 2024-12-17 10:58:09 +00:00
[#305] tree/pool: Add flag to use net map to prioritize tree services

Okay, let me clarify what I really meant:

  1. err can be assigned with context cancellation errors as context is propagated through functor but that may happen on stream opening, not on…
aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#305 2024-12-17 10:54:05 +00:00
[#305] tree/pool: Add flag to use net map to prioritize tree services

I suppose the context is going to be propagated through functor

err := p.requestWithRetry(ctx, prm.CID, func(client *rpcclient.Client) (inErr error) {
		resp, inErr = rpcapi.Add(client,
aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#305 2024-12-17 10:24:22 +00:00
[#305] tree/pool: Add flag to use net map to prioritize tree services

Let me highlight some points about this method

aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#305 2024-12-17 09:48:36 +00:00
[#305] tree/pool: Add flag to use net map to prioritize tree services

It seems any error from ctx.Error() make any dialing call with ctx not redialable as ctx is already Done() ctx.Error() != nil could be enough?

aarifullin deleted tag 0.44.4 from TrueCloudLab/frostfs-node 2024-12-17 08:24:39 +00:00
aarifullin pushed tag 0.44.4 to TrueCloudLab/frostfs-node 2024-12-17 08:24:21 +00:00