Airat Arifullin aarifullin
0 followers · 0 following
  • Joined on 2023-03-16
Repositories
16
 Projects Packages Code Public activity Starred repositories
aarifullin commented on pull request TrueCloudLab/frostfs-node#1453 2024-12-11 09:46:24 +00:00
container: Add ListStream method

Could you, please, use another naming for the variable? I mean, ...V1 suffix seems inconvenient as it may be mistaken for old api-go version.

aarifullin approved TrueCloudLab/frostfs-node#1551 2024-12-11 08:13:29 +00:00
Fix checking EC parent existence on Put object to shard support/v0.44
aarifullin approved TrueCloudLab/frostfs-node#1548 2024-12-10 12:16:18 +00:00
Fix checking EC parent existence on Put object to shard
aarifullin commented on issue TrueCloudLab/frostfs-sdk-go#308 2024-12-10 11:28:03 +00:00
client: (*Client).Dial seems to be redundant

Dial is used in frostfs-node's multiclient within createForAddress. The problem is…

aarifullin approved TrueCloudLab/frostfs-sdk-go#291 2024-12-10 10:11:29 +00:00
container: Add ListStream method

LGTM

aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#291 2024-12-10 10:11:03 +00:00
container: Add ListStream method

I meant - to leave a comment in the code :) to describe the field. But as far as I see you fixed the field's name. So, the comment is not required

aarifullin pushed to fix/grpc_healthcheck at aarifullin/frostfs-node 2024-12-06 12:29:58 +00:00
7e542906ef [#1539] go.mod: Bump frostfs-sdk-go version
d1bc4351c3 [#1545] morph/event: Simplify frostfs contract event parsing
Compare 2 commits »
aarifullin pushed to fix/grpc_healthcheck at aarifullin/frostfs-node 2024-12-06 12:21:59 +00:00
89e8a117e5 [#1539] go.mod: Bump frostfs-sdk-go version
aarifullin pushed to fix/grpc_healthcheck at aarifullin/frostfs-node 2024-12-06 12:10:38 +00:00
dd9eabfcdd [#1539] object manager: Fix placement unit-test
aarifullin pushed to fix/grpc_healthcheck at aarifullin/frostfs-node 2024-12-06 11:49:11 +00:00
b8c3a6e53e [#1539] go.mod: Bump frostfs-sdk-go version
aarifullin pushed to fix/grpc_healthcheck at aarifullin/frostfs-node 2024-12-06 11:44:53 +00:00
65ace5df48 [#1539] go.mod: Bump frostfs-sdk-go version
c83ec1092e [#1539] node: Support healthcheck server for gRPC services
1c12f23b84 [#1541] morph/event: Simplify netmap contract event parsing
a353d45742 [#1541] morph/event: Simplify container contract event parsing
d5c46d812a [#1541] go.mod: Update frostfs-contract
Compare 11 commits »
aarifullin approved TrueCloudLab/frostfs-node#1541 2024-12-06 10:17:46 +00:00
morph/event: Reuse auto-generated parsers
aarifullin pushed to fix/grpc_client at aarifullin/frostfs-sdk-go 2024-12-06 08:32:45 +00:00
e08403faba [#301] rpc: Make client stream initialization get cancelled by dial timeout
aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#304 2024-12-06 08:20:24 +00:00
Make rpc client stream initialization get cancelled by dial timeout

Check the changes out, please. Now it's closed if timer has expired

aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#304 2024-12-06 08:18:47 +00:00
Make rpc client stream initialization get cancelled by dial timeout

I am sorry. When I read your comment first time:

  • times fires
  • stream, nil is returned from NewStream
  • context is cancelled

I mistook these points for "any of this" case. So, now…

aarifullin pushed to fix/grpc_client at aarifullin/frostfs-sdk-go 2024-12-06 08:15:36 +00:00
7d53887170 [#301] rpc: Make client stream initialization get cancelled by dial timeout
aarifullin pushed to fix/grpc_client at aarifullin/frostfs-sdk-go 2024-12-06 07:47:49 +00:00
c3bb283cce [#301] rpc: Make client stream initialization get cancelled by dial timeout
aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#304 2024-12-06 07:24:16 +00:00
Make rpc client stream initialization get cancelled by dial timeout

Sure we don't. Fixed

aarifullin pushed to fix/grpc_client at aarifullin/frostfs-sdk-go 2024-12-06 07:22:59 +00:00
cbc59f82fb [#301] rpc: Make client stream initialization get cancelled by dial timeout
aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#304 2024-12-05 14:19:27 +00:00
Make rpc client stream initialization get cancelled by dial timeout

It is true that stream from (2) should be closed?

I suppose we don't need to close if it's successfully/unsuccessfully opened . The goal of this fix is to prevent hung open_ing_. So, if we…