Airat Arifullin aarifullin
  • Joined on 2023-03-16
aarifullin commented on pull request TrueCloudLab/frostfs-node#257 2023-04-17 10:42:52 +00:00
[#19] node: Make policier read shards concurrently

Added getShardIDs and createMultiCursor but left listWithMultiCursor because the function became uglier with that :) But funlen is fine with this function anyway

aarifullin pushed to feature/19-list_mul_cursor at aarifullin/frostfs-node 2023-04-17 10:30:53 +00:00
4ae6ada5f3 [#19] node: Make policier read shards concurrently
aarifullin commented on pull request TrueCloudLab/frostfs-node#257 2023-04-17 08:04:36 +00:00
[#19] node: Make policier read shards concurrently

Why did you choose to add a method instead of extending a ListWithCursor then?

ListWithCursor tells the client that shards won't be read concurrently wherever ListWithMultiCursor tells…

aarifullin commented on pull request TrueCloudLab/frostfs-node#257 2023-04-17 07:40:06 +00:00
[#19] node: Make policier read shards concurrently

If I say count=5, will it iterate over 5 random shards?

Yes, if len(shards) == 5. But if count == 5 and len(shards) == 4, then count gets 4. One cursor matches to one shard

As…

aarifullin commented on pull request TrueCloudLab/frostfs-node#257 2023-04-17 07:35:41 +00:00
[#19] node: Make policier read shards concurrently

Briefly: no way

When I tried many ways to manage reading shards from the policer but nothing succeeded. If ListWithCursor is used, then shards are re-read few times. We don't need it

aarifullin commented on pull request TrueCloudLab/frostfs-node#257 2023-04-17 07:29:55 +00:00
[#19] node: Make policier read shards concurrently

Sorry. Now I've got it. I'll fix it, thanks!

aarifullin commented on pull request TrueCloudLab/frostfs-node#257 2023-04-17 07:06:29 +00:00
[#19] node: Make policier read shards concurrently

Ok, fare point

aarifullin commented on pull request TrueCloudLab/frostfs-node#257 2023-04-17 07:05:49 +00:00
[#19] node: Make policier read shards concurrently

Yes, it can. You can check ListWithCursor implementation that has the same logic. Also, you can check shardPolicyWorker to understand the principle of cursor usage

aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#55 2023-04-17 06:54:38 +00:00
client: Simplify netmap/session methods

I think it's more natural to return nil instead &res in the error case

aarifullin commented on pull request TrueCloudLab/frostfs-sdk-go#55 2023-04-17 06:48:03 +00:00
client: Simplify netmap/session methods

or toRequest

aarifullin approved TrueCloudLab/frostfs-sdk-go#54 2023-04-17 06:47:01 +00:00
Drop subnet
aarifullin approved TrueCloudLab/frostfs-api#24 2023-04-17 06:46:04 +00:00
Del/Drop reputation system support

Just for my curiosity. The issue says:

aarifullin commented on pull request TrueCloudLab/frostfs-node#233 2023-04-16 18:32:36 +00:00
[#118] node: add unit concurrent tests for blobstor

Fixed 👍

aarifullin pushed to feature/blobstor_concurrent_tests at aarifullin/frostfs-node 2023-04-16 18:32:14 +00:00
1478cf631a [#118] node: add unit concurrent tests for blobstor
aarifullin created pull request TrueCloudLab/frostfs-node#257 2023-04-16 14:08:57 +00:00
[#19] node: Make policier read shards concurrently
aarifullin created branch feature/19-list_mul_cursor in aarifullin/frostfs-node 2023-04-16 14:06:45 +00:00
aarifullin pushed to feature/19-list_mul_cursor at aarifullin/frostfs-node 2023-04-16 14:06:45 +00:00
d99b94340b [#19] node: Make policier read shards concurrently
262c9c2b93 [#256] blobovniczaTree: Make Exists test stable
0b42a00a60 [#254] innerring: Remove unused TimersHandlers() method from processors
8466894fdf [#250] control: remove DumpShard and RestoreShard RPC
070154d506 [#247] client: Drop reputation related RPCs
Compare 10 commits »
aarifullin approved TrueCloudLab/frostfs-node#251 2023-04-14 11:34:29 +00:00
[#250] control: remove DumpShard and RestoreShard RPC