Airat Arifullin aarifullin
  • Joined on 2023-03-16
aarifullin commented on pull request TrueCloudLab/frostfs-node#1655 2025-02-25 13:28:54 +00:00
Improve debug logging for APE check failures

Fixed

aarifullin pushed to feat/improve_ape_log at aarifullin/frostfs-node 2025-02-25 13:28:48 +00:00
bd30e4838f [#1574] container: Introduce debug logging for APE check failures
6b2bce21d1 [#1572] ape: Make ChainRouterError constructor public
e1c6b68967 [#1574] tree: Introduce debug logging for APE check failures
c2bd1ace3f [#1574] object: Introduce debug logging for APE check failures
55ac22dd8c [#1574] ape: Extend ChainRouterError
Compare 5 commits »
aarifullin commented on pull request TrueCloudLab/frostfs-node#1655 2025-02-25 09:55:56 +00:00
Improve debug logging for APE check failures

Logging an error is one way to handle an error.

Are you talking about auto-tests? Because I have no idea who else might be processing error from debug logs.

Do you have any other…

aarifullin commented on pull request TrueCloudLab/frostfs-node#1655 2025-02-25 09:03:55 +00:00
Improve debug logging for APE check failures

@dkirillov wrote in TrueCloudLab/frostfs-node#1655 (comment):

LGTM, but what about container operations?

Oh, true. Forgot about this service. Let me…

aarifullin created pull request TrueCloudLab/frostfs-node#1655 2025-02-24 16:53:58 +00:00
Improve debug logging for APE check failures
aarifullin created branch feat/improve_ape_log in aarifullin/frostfs-node 2025-02-24 16:50:26 +00:00
aarifullin pushed to feat/improve_ape_log at aarifullin/frostfs-node 2025-02-24 16:50:26 +00:00
060e4b2f76 [#1574] tree: Introduce debug logging for APE check failures
521e72b995 [#1574] object: Introduce debug logging for APE check failures
b83bce1435 [#1574] ape: Extend ChainRouterError
00faa9f854 [#1574] ape: Introduce Properties() method for Request and Resource
02f3a7f65c [#1648] writecache: Fix race condition when reporting cache size metrics
Compare 10 commits »
aarifullin commented on issue TrueCloudLab/frostfs-node#1572 2025-02-24 12:50:07 +00:00
Incorrect APE processing with object attribute condition for DeleteObject

The problem is that we may ignore an error and violate APE processing rules.

We're not ignoring an error as we just don't get any in this case

The problem is not that the second…

aarifullin commented on pull request TrueCloudLab/policy-engine#97 2025-02-24 12:10:51 +00:00
Ignore local overrides with Allow status in chain router

@fyrchik wrote in TrueCloudLab/policy-engine#97 (comment):

If a target owner sets some private rules into morph, then the access may be intentionally/…

aarifullin commented on pull request TrueCloudLab/frostfs-node#1650 2025-02-24 11:23:36 +00:00
Fix sorted getSubtree for multiversion filenames

UPD: added mergeByFilenames invocation. So, referring to the previous example: Instead of result = 13, 15, 20, 33, 45, 1, 14, 29, we get result = 13, 15, 1, 14, 20, 29, 33, 45. So, for…

aarifullin pushed to fix/1642_getsortsubtree at aarifullin/frostfs-node 2025-02-24 11:20:25 +00:00
e46195c4c2 [#1642] tree: Fix sorted getSubtree for multiversion filenames
aarifullin commented on pull request TrueCloudLab/frostfs-node#1650 2025-02-24 10:34:35 +00:00
Fix sorted getSubtree for multiversion filenames

done

aarifullin pushed to fix/1642_getsortsubtree at aarifullin/frostfs-node 2025-02-24 10:31:30 +00:00
ffd2ff133d [#1642] tree: Fix sorted getSubtree for multiversion filenames
aarifullin commented on pull request TrueCloudLab/frostfs-node#1650 2025-02-24 09:13:11 +00:00
Fix sorted getSubtree for multiversion filenames

You should refer to fillSortedChildren implementation. The main idea is that "same-version1" won't have the IDs of "same-version". That's why I used the term flattened result that is…

aarifullin commented on pull request TrueCloudLab/frostfs-node#1650 2025-02-24 07:22:32 +00:00
Fix sorted getSubtree for multiversion filenames

if filename > start

But the branch executes only

else if filename == *h.start {
   /*. . .*/
}
  1. t.fillSortedChildren(b, nodeIDs, h) invoked first time. It tries to push…
aarifullin created pull request TrueCloudLab/policy-engine#97 2025-02-21 13:52:20 +00:00
Ignore local overrides with Allow status in chain router
aarifullin created branch fix/83_ignore_override_allow in aarifullin/policy-engine 2025-02-21 13:51:40 +00:00
aarifullin pushed to fix/83_ignore_override_allow at aarifullin/policy-engine 2025-02-21 13:51:40 +00:00
d1db407c72 [#83] router: Ignore local overrides with Allow status
9c98b05066 [#96] Add CODEOWNERS
Compare 2 commits »
aarifullin commented on issue TrueCloudLab/policy-engine#83 2025-02-21 13:05:49 +00:00
Fix chain router for local overrides

A unit-test to check this fact:

func TestIfLocalOverrideOverridesMorph(t *testing.T) {
	const (
		namespace = ""
		object    = "native:object//73tQMTYyUkTgmvPR1HWib6pndbhSoBovbnMF7Pws8Rc…