ale64bit

ale64bit commented on pull request TrueCloudLab/frostfs-node#245

2023-04-13 11:51:07 +00:00

node: Read config files from dir even if config file not set via --config

Consider simplifying to

ale64bit commented on pull request TrueCloudLab/frostfs-node#245

2023-04-13 11:51:07 +00:00

node: Read config files from dir even if config file not set via --config

inline the value if it's not actually needed:

ale64bit suggested changes for TrueCloudLab/frostfs-node#245

2023-04-13 11:51:07 +00:00

node: Read config files from dir even if config file not set via --config

ale64bit commented on pull request TrueCloudLab/frostfs-node#233

2023-04-13 08:11:21 +00:00

[#118] node: add unit concurrent tests for blobstor

the zero WaitGroup is valid:

ale64bit commented on pull request TrueCloudLab/frostfs-node#233

2023-04-13 08:10:35 +00:00

[#118] node: add unit concurrent tests for blobstor

cute loop. But why? Just because it's slightly shorter to type or is there another reason?

ale64bit commented on pull request TrueCloudLab/frostfs-node#233

2023-04-13 08:09:14 +00:00

[#118] node: add unit concurrent tests for blobstor

What kind of bugs are they supposed to catch?

As far as I understood the issue, here we should check logical…

ale64bit commented on issue TrueCloudLab/frostfs-node#162

2023-04-11 08:34:48 +00:00

Logs linter

Could you add some code examples of what sort of things the linter would highlight?

ale64bit commented on pull request TrueCloudLab/frostfs-node#233

2023-04-11 08:13:13 +00:00

[#118] node: add unit concurrent tests for blobstor

I'm a bit skeptical about the value of these tests. A few questions:

What kind of bugs are they supposed to catch?
Did you try introducing such a bug intentionally to verify that they…

ale64bit commented on pull request TrueCloudLab/xk6-frostfs#48

2023-04-11 08:02:36 +00:00

[#14] Add s3 local loader

done (I don't prefer it, it's an oversight)

ale64bit commented on pull request TrueCloudLab/xk6-frostfs#48

2023-04-11 08:02:20 +00:00

[#14] Add s3 local loader

done

ale64bit commented on pull request TrueCloudLab/xk6-frostfs#48

2023-04-11 08:02:13 +00:00

[#14] Add s3 local loader

done

ale64bit commented on pull request TrueCloudLab/xk6-frostfs#48

2023-04-11 08:01:16 +00:00

[#14] Add s3 local loader

done

ale64bit commented on pull request TrueCloudLab/xk6-frostfs#48

2023-04-11 08:00:38 +00:00

[#14] Add s3 local loader

done. Let's do a separate PR.

ale64bit pushed to feature/14-local_s3 at ale64bit/xk6-frostfs

2023-04-11 07:53:44 +00:00

11efc73678 [#14] Add s3 local loader

ale64bit pushed to feature/14-local_s3 at ale64bit/xk6-frostfs

2023-04-11 07:52:11 +00:00

14cc78dbc3 [#14] Add s3 local loader

ale64bit approved TrueCloudLab/frostfs-node#223

2023-04-10 11:02:51 +00:00

Refactorings

ale64bit commented on pull request TrueCloudLab/frostfs-node#223

2023-04-10 09:40:12 +00:00

Refactorings

remove this, since a default case was added?

ale64bit commented on pull request TrueCloudLab/frostfs-node#223

2023-04-10 09:40:12 +00:00

Refactorings

Maybe expand the error? fmt.Errorf("validating tombstone: %v", err)

ale64bit commented on pull request TrueCloudLab/frostfs-node#223

2023-04-10 09:40:12 +00:00

Refactorings

can we avoid the acronym 'SG' here?

ale64bit commented on pull request TrueCloudLab/frostfs-node#223

2023-04-10 09:40:12 +00:00

Refactorings

do we have some rule to not one-line these? (same below)