ale64bit
  • Joined on 2023-03-06
ale64bit closed pull request TrueCloudLab/frostfs-node#671 2023-09-01 08:44:49 +00:00
[#xx] Add general sanity tests for object stores
ale64bit commented on pull request TrueCloudLab/frostfs-node#671 2023-09-01 08:07:51 +00:00
[#xx] Add general sanity tests for object stores

I would like these generic tests suites to have specific purpose, not scattered around the codebase.

Cool. Note that "generic" means that the purpose might not be "specific".

Does it…

ale64bit commented on pull request TrueCloudLab/frostfs-node#671 2023-09-01 07:44:03 +00:00
[#xx] Add general sanity tests for object stores

Not sure there's an actual difference for us between a "blob" and an "object" from the storage viewpoint. Why to move it there?

Anyway, it's intended to be used everywhere it can be plugged in.…

ale64bit commented on pull request TrueCloudLab/frostfs-node#654 2023-09-01 07:39:47 +00:00
WIP: Experimental bitcask-based writecache implementation

They should be executed in settings that are representative of how they will be used; we can't arbitrarily change parameters in a production deployment to match a specific workload.

This…

ale64bit pushed to feature/flat-blobstore-test at ale64bit/frostfs-node 2023-09-01 07:35:52 +00:00
440cf85d62 [#18] Add badgerstore substorage implementation
b9b86d2ec8 [#666] shard/test: Fix data race in metrics tests
4dff9555f1 [#568] writecache: Improve flushing scheme for badger
806cc13d9f [#658] client: Refactor PrmObjectGet/Head/Range usage
1daef2ceeb [#660] writecache: Fix remaining addr2key uses
Compare 105 commits »
ale64bit pushed to feature/store-basic-sanity-test at ale64bit/frostfs-node 2023-08-31 14:23:05 +00:00
98744aa5e1 [#671] Add general sanity tests for object stores
ale64bit created pull request TrueCloudLab/frostfs-node#671 2023-08-31 14:22:35 +00:00
[#xx] Add general sanity tests for object stores
ale64bit created branch feature/store-basic-sanity-test in ale64bit/frostfs-node 2023-08-31 14:22:07 +00:00
ale64bit pushed to feature/store-basic-sanity-test at ale64bit/frostfs-node 2023-08-31 14:22:07 +00:00
6cceca4239 [#xx] Add general sanity tests for object stores
ale64bit commented on pull request TrueCloudLab/frostfs-node#654 2023-08-31 12:54:14 +00:00
WIP: Experimental bitcask-based writecache implementation

Speaking of benchmarks -- sequential benchmarks are affected by the batch delay and batch size. Have you made batch_size=1 for bbolt? Parallel benchmarks need to be executed in similar…

ale64bit pushed to feature/wc-experiment at ale64bit/frostfs-node 2023-08-31 11:17:24 +00:00
42e74d6aab [#610] Add bitcask-inspired writecache implementation
ale64bit commented on pull request TrueCloudLab/frostfs-node#654 2023-08-31 10:30:03 +00:00
WIP: Experimental bitcask-based writecache implementation

Results from basic benchmarks:

$ go test -benchmem -run=^$ -benchtime 1m -cpu 1 -timeout 1h -bench ^BenchmarkWritecacheSeq$ git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_stora…
ale64bit pushed to feature/wc-experiment at ale64bit/frostfs-node 2023-08-31 10:28:18 +00:00
f8583060ec [#610] Add bitcask-inspired writecache implementation
ale64bit pushed to feature/wc-experiment at ale64bit/frostfs-node 2023-08-31 09:29:56 +00:00
cf50a6b9c6 [#xx] Add bitcask-inspired writecache implementation
b9b86d2ec8 [#666] shard/test: Fix data race in metrics tests
4dff9555f1 [#568] writecache: Improve flushing scheme for badger
806cc13d9f [#658] client: Refactor PrmObjectGet/Head/Range usage
1daef2ceeb [#660] writecache: Fix remaining addr2key uses
Compare 14 commits »
ale64bit commented on pull request TrueCloudLab/frostfs-node#660 2023-08-30 13:21:51 +00:00
writecache: Fix remaining addr2key uses

@ale64bit I thought Generic tests are exactly like this (and more comprehensive) -- it seems not.

In this particular case, the test caught it because it deletes twice the same key, which…

ale64bit commented on pull request TrueCloudLab/frostfs-node#660 2023-08-30 12:18:19 +00:00
writecache: Fix remaining addr2key uses

Are these errors caught by tests?

Not currently, AFAIK. I discovered it with a test for the lite cache: TrueCloudLab/frostfs-node#654/files

ale64bit pushed to feature/wc-experiment at ale64bit/frostfs-node 2023-08-30 11:32:06 +00:00
30fc6b56bd [#xx] Experimental lite writecache implementation
ale64bit pushed to fix/badger-delete-addr-bug at ale64bit/frostfs-node 2023-08-29 12:27:57 +00:00
3781479a85 [#660] writecache: Fix remaining addr2key uses
ale64bit created pull request TrueCloudLab/frostfs-node#660 2023-08-29 12:27:32 +00:00
[#xx] writecache: Fix remaining addr2key uses