ale64bit
  • Joined on 2023-03-06
ale64bit commented on pull request TrueCloudLab/frostfs-node#223 2023-04-10 09:40:12 +00:00
Refactorings

why the local variable?

ale64bit suggested changes for TrueCloudLab/frostfs-node#223 2023-04-10 09:40:12 +00:00
Refactorings
ale64bit commented on pull request TrueCloudLab/xk6-frostfs#48 2023-04-10 08:01:56 +00:00
[#14] Add s3 local loader

A bit of context:

This PR implements a local k6 loader implementation for S3 use-cases, as described in #14. Specifically, it can be used to stop services in a given cluster and fill each node…

ale64bit commented on pull request TrueCloudLab/xk6-frostfs#48 2023-04-10 07:25:14 +00:00
[#14] Add s3 local loader

Because all methods that return this type (or similar) are used in JavaScript side, so a compatible type (and number of return values) must be used.

See e.g. https://git.frostfs.info/TrueCloudLa

ale64bit created pull request TrueCloudLab/xk6-frostfs#48 2023-04-07 12:40:25 +00:00
[#14] Add s3 local loader
ale64bit pushed to feature/14-local_s3 at ale64bit/xk6-frostfs 2023-04-07 12:39:19 +00:00
41f0ed808d [#14] Add s3 local loader
ale64bit pushed to feature/14-local_s3 at ale64bit/xk6-frostfs 2023-04-07 12:30:45 +00:00
f0246769c2 [#14] Add s3 local loader
ale64bit created repository ale64bit/frostfs-s3-gw 2023-04-04 09:41:21 +00:00
ale64bit opened issue TrueCloudLab/frostfs-s3-gw#75 2023-04-03 06:43:10 +00:00
Cannot import tree service interface package
ale64bit created branch feature/14-local_s3 in ale64bit/xk6-frostfs 2023-03-31 10:30:46 +00:00
ale64bit pushed to feature/14-local_s3 at ale64bit/xk6-frostfs 2023-03-31 10:30:46 +00:00
cabf7fcd31 [WIP] s3local loader
ef6f5bdf48 [#45] scenarios: Support ENV file in local.js
cea265a3f8 [#43] generator: Fix initial payload generation
220a822377 [#39] Add bug label; edit feature request
7efb6315dc [#14]: Add local target support
Compare 6 commits »
ale64bit commented on pull request TrueCloudLab/frostfs-node#192 2023-03-31 07:06:53 +00:00
WIP: config: Rename .yaml to .yml

what's wrong with .yaml? should we also change to .jon or jsn then?

ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 14:26:40 +00:00
[#139] test: Add test storage implementation

hm, I ran go mod tidy. I don't really touch these files manually. Maybe it's ok now.

ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 14:26:13 +00:00
[#139] test: Add test storage implementation

ah I see. Yes, good point. I added a comment about it on this line.

ale64bit pushed to fix/139-unit_test_storage at ale64bit/frostfs-node 2023-03-29 14:25:46 +00:00
6df9f44cfd [#139] test: Add test storage implementation
ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 11:55:14 +00:00
[#139] test: Add test storage implementation

os.Chmod was used here to cause the file to not be read properly, but the same can be achieved with os.Truncate so that it can't be unmarshalled. I thought at least os.Truncate didn't depend…

ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 11:53:59 +00:00
[#139] test: Add test storage implementation

done. Is there any value in returning an error that is guaranteed to not be specially handled or better to use a relevant error for this path?

ale64bit commented on pull request TrueCloudLab/frostfs-node#173 2023-03-29 11:52:52 +00:00
[#139] test: Add test storage implementation

This is intentional, so that a TreeStore can also be used purely as a mock (e.g. to verify only certain calls are executed and nothing is propagated to any underlying storage). Re. the implicit…