ale64bit
  • Joined on 2023-03-06
ale64bit approved TrueCloudLab/frostfs-node#174 2023-03-24 09:42:05 +00:00
go.mod: Update dependencies

LGTM (but precommit wants you to format the commit message)

ale64bit pushed to fix/139-unit_test_storage at ale64bit/frostfs-node 2023-03-24 09:31:13 +00:00
4907d78dab [#139] test: Add test storage implementation
9ffa0d8fea [#171] Remove unit tests from pipeline
d857ffeb2e [#171] Syncrhonize pre-commit settings across FrostFS repos
34329d67ff [#86] node: Fix unit test and linter errors
9808dec591 [#86] node: Move testing utils to one package
Compare 7 commits »
ale64bit created pull request TrueCloudLab/frostfs-node#173 2023-03-24 09:27:14 +00:00
[#139] test: Add test storage implementation
ale64bit pushed to fix/139-unit_test_storage at ale64bit/frostfs-node 2023-03-24 09:25:27 +00:00
f6b6097f0c [#139] test: Add test storage implementation
ale64bit commented on pull request TrueCloudLab/xk6-frostfs#44 2023-03-24 07:02:09 +00:00
registry: optimize object marshaling

not that it matters, but this never generates 'z'.

ale64bit commented on pull request TrueCloudLab/frostfs-node#30 2023-03-24 06:55:03 +00:00
[#1248] node: Do not update cache twice

if you happen to keep this version, it probably should be

ale64bit commented on pull request TrueCloudLab/frostfs-node#30 2023-03-23 09:28:54 +00:00
[#1248] node: Do not update cache twice

Sure, but this usage seems to fall into the description on the next paragraph after the one you are quoting, isn't? And type safety is a non-concern given that the parent type is polymorphic.

ale64bit commented on pull request TrueCloudLab/frostfs-node#30 2023-03-23 09:19:38 +00:00
[#1248] node: Do not update cache twice

not sure if it's a common practice, but I normally see the mutex declared right before the thing it guards.

ale64bit commented on pull request TrueCloudLab/frostfs-node#30 2023-03-23 09:19:38 +00:00
[#1248] node: Do not update cache twice

is it simpler to use https://pkg.go.dev/sync#Map and avoid all the mutexes?

ale64bit commented on pull request TrueCloudLab/frostfs-node#160 2023-03-23 06:55:31 +00:00
[#139] test: Add test storage implementation

No point since mocks are avoided.

ale64bit closed pull request TrueCloudLab/frostfs-node#160 2023-03-23 06:55:31 +00:00
[#139] test: Add test storage implementation
ale64bit commented on pull request TrueCloudLab/frostfs-node#160 2023-03-23 06:55:05 +00:00
[#139] test: Add test storage implementation

I see.

ale64bit commented on issue TrueCloudLab/frostfs-node#139 2023-03-22 08:25:35 +00:00
Unit tests fail in docker container under root user

Let me know if the changes in #160 look reasonable. I'm not a big fan of mocking in general, but in measure I guess it's better than chmodding stuff or depending on particular conditions (such as…

ale64bit created pull request TrueCloudLab/frostfs-node#160 2023-03-22 08:19:27 +00:00
[#139] test: Add test storage implementation
ale64bit pushed to fix/139-unit_test_storage at ale64bit/frostfs-node 2023-03-22 08:17:54 +00:00
3fb064649f [#139] test: Add test storage implementation
ale64bit pushed to fix/139-unit_test_storage at ale64bit/frostfs-node 2023-03-22 07:54:22 +00:00
e0879ffc87 [#139] test: Add test storage implementation
da8da1c63a [#98] fstree: Do not fail iteration over just removed files
49234b915e [#155] search-service: Fix search with ST
1637a3edce [#155] search-service: Add search with ST test
cbc2efb1d6 [#156] object/get: Make toHeadPrm() pass gocognit
Compare 18 commits »
ale64bit pushed to feature/14-local_targets at ale64bit/xk6-frostfs 2023-03-21 12:10:52 +00:00
0cb5b4dc98 [#14]: Add local target support
ale64bit created branch fix/139-unit_test_storage in ale64bit/frostfs-node 2023-03-21 10:39:02 +00:00
ale64bit pushed to fix/139-unit_test_storage at ale64bit/frostfs-node 2023-03-21 10:39:02 +00:00
43226423fa [#139] Add test storage implementation
9cd8f7cea0 [#152] IR: Process empty basic incomes
44b86bac5a [#148] linter: Add contextcheck linter
481a1ca6f3 [#148] linter: Add gocognit linter
97c36ed3ec [#148] linter: Add funlen linter
Compare 10 commits »