Stephen J Day
f6d75a6139
Return after error in handler
...
This adds a missing return statement. It is not strictly needed since if the
io.Copy fails, the Finish operation will fail. Currently, the client reports
both errors where this new code will correctly only report the io.Copy error.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-23 13:13:13 -07:00
Stephen Day
73960f4024
Merge pull request #419 from stevvooe/pool-buffers-s3
...
Pool buffers used in S3.WriteStream
2015-04-22 16:41:28 -07:00
Stephen J Day
1adab029f6
Pool buffers used in S3.WriteStream
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 16:25:53 -07:00
Olivier Gambier
506a5b4a97
Merge pull request #418 from stevvooe/accept-chunksize-parameter
...
Allow configuration of chunksize parameter
2015-04-22 14:46:40 -07:00
Stephen J Day
72a702d0d9
Allow configuration of chunksize parameter
...
The code using values from the yaml package wasn't careful enought with the
possible incoming types. Turns out, it is just an int but we've made this
section somewhat bulletproof in case that package changes the behavior.
This code likely never worked. The configuration system should be decoupled
from the object instantiation.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 14:31:34 -07:00
Stephen Day
cc1bd58d0f
Merge pull request #416 from stevvooe/remove-go13-test
...
Disable go1.3 tests for circle and upgrade to go1.4.2
2015-04-22 13:28:36 -07:00
Stephen Day
cbfce39acb
Merge pull request #415 from stevvooe/update-goamz
...
Update goamz package dependency
2015-04-22 13:06:46 -07:00
Stephen J Day
36093aaf8b
Disable go1.3 tests for circle and upgrade to go1.4.2
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 12:57:22 -07:00
Stephen Day
e59046e598
Merge pull request #414 from stevvooe/check-error-copy
...
Check error returned from io.Copy
2015-04-22 12:46:55 -07:00
Stephen J Day
4330627c71
Check error returned from io.Copy
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 12:35:08 -07:00
Stephen J Day
9bd1186654
Update goamz package dependency
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 12:32:59 -07:00
Stephen Day
aa09c6c262
Merge pull request #408 from stevvooe/increase-retry-backoff
...
Backoff retry on verification to give s3 time to propagate
2015-04-21 13:19:28 -07:00
Stephen J Day
632e46418b
Backoff retry on verification to give s3 time to propagate
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-21 13:04:46 -07:00
Stephen Day
ad69b9d984
Merge pull request #407 from stevvooe/log-canonical-digest
...
log canonical digest on verification error
2015-04-21 13:03:32 -07:00
Stephen J Day
d8dbcc3efa
log canonical digest on verification error
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-21 11:34:18 -07:00
Olivier Gambier
1b975e980b
Merge pull request #405 from stevvooe/eventual-consistency
...
Attempt to deal with eventual consistency by retrying
2015-04-20 18:59:01 -07:00
Stephen Day
70e6ad6ef1
Merge pull request #404 from RichardScothern/digest-log
...
Add logging for generic handler errors.
2015-04-20 18:51:59 -07:00
Stephen J Day
c8345090d9
Attempt to deal with eventual consistency by retrying
...
Rather than accept the resulting of a layer validation, we retry up to three
times, backing off 100ms after each try. The thought is that we allow s3 files
to make their way into the correct location increasing the liklihood the
verification can proceed, if possible.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-20 18:49:22 -07:00
Richard
3a1029a262
Add logging for generic handler errors.
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-04-20 17:47:52 -07:00
Stephen Day
75e78e31de
Merge pull request #399 from stevvooe/response-writer-context
...
context: return instrumented response writer from context
2015-04-20 13:39:18 -07:00
Stephen J Day
cb938c476f
Return instrumented response writer from context
...
This is ensures that users of the ResponseWriter from the context correctly
track usage. Otherwise, context reporting is incorrect.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-20 11:15:01 -07:00
Stephen Day
f3097d716e
Merge pull request #392 from moxiegirl/post-releas-updates
...
Couple of post-release Fixes
2015-04-20 11:12:41 -07:00
Mary Anthony
d588ed13b2
Fixes #391 for registry top page
...
Fixes #390 to add building link to README
Docker Registry Service to Docker Registry
Signed-off-by: Mary Anthony <mary@docker.com>
2015-04-18 17:32:57 -07:00
Stephen Day
a9a9658e41
Merge pull request #388 from mika/master
...
docs: drop newlines in URLs to avoid 404
2015-04-17 16:54:09 -07:00
Stephen Day
22c72773f6
Merge pull request #389 from DreadPirateShawn/fixtypos
...
Fix deployment guide typos re: image name consistency.
2015-04-17 16:51:31 -07:00
Shawn Falkner-Horine
85cc6bc4bb
Fix deployment guide typos re: image name consistency.
...
Signed-off-by: Shawn Falkner-Horine <dreadpirateshawn@gmail.com>
2015-04-17 21:13:24 +00:00
Michael Prokop
647e0a48b3
docs: drop newlines in URLs to avoid 404
...
The docs as available at
https://github.com/docker/distribution/blob/master/docs/configuration.md
result in 404 errors:
https://github.com/docker/distribution/blob/master/cmd/registry/%0Aconfig.yml
http://docs.aws.amazon.com/AWSSecurityCredentials/1.0/%0AAboutAWSCredentials.html#KeyPairs
instead of pointing to the correct ones, being:
https://github.com/docker/distribution/blob/master/cmd/registry/config.yml
http://docs.aws.amazon.com/AWSSecurityCredentials/1.0/AboutAWSCredentials.html#KeyPairs
So avoid the newlines in the corresponding source files.
Signed-off-by: Michael Prokop <mika@grml.org>
2015-04-17 23:09:43 +02:00
Stephen Day
7c25fcf698
Merge pull request #375 from RichardScothern/path-logging
...
registry/storage/driver: add path and other info to filesytem trace methods.
2015-04-17 14:09:23 -07:00
Richard
6b1c2e9b1f
Add path and other info to filesytem trace methods.
...
Also fix Delete (was 'Move').
2015-04-17 13:55:18 -07:00
Stephen Day
7c760146bd
Merge pull request #384 from liubin/fixtypos
...
fix some typos in source comments
2015-04-17 11:55:19 -07:00
bin liu
e0521d2d01
fix some typos in source comments
...
Signed-off-by: bin liu <liubin0329@gmail.com>
2015-04-17 12:39:52 +00:00
Stephen Day
5ded64812a
Merge pull request #376 from nubs/patch-1
...
docs: fix registry link to point to localhost in deploy doc
2015-04-16 15:38:06 -07:00
Spencer Rinehart
570fedb2ab
Fix registry link to point to localhost in deploy doc.
...
Signed-off-by: Spencer Rinehart <anubis@overthemonkey.com>
2015-04-16 17:16:42 -05:00
Stephen Day
62b70f951f
Merge pull request #374 from stevvooe/release-preparation
...
Release preparation
2015-04-16 11:27:48 -07:00
Stephen J Day
aa74de8824
Update rough version for release
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-16 11:25:03 -07:00
Stephen J Day
04a6446e90
Update AUTHORS file for releease.
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-16 11:23:56 -07:00
Stephen Day
cce1641f9b
Merge pull request #333 from RichardScothern/purgeuploads
...
registry/storage: automatically purge old upload files
2015-04-16 11:16:51 -07:00
Olivier Gambier
604d39bbed
Merge pull request #373 from bfirsh/use-tag-in-docker-run
...
Use registry:2.0 tag in docker run
2015-04-16 11:16:33 -07:00
Ben Firshman
5e4deba5a4
Use registry:2.0 tag in docker run
...
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
2015-04-16 11:11:03 -07:00
Richard
e4f07c368b
Automatically purge old upload files.
...
When the registry starts a background timer will periodically
scan the upload directories on the file system every 24 hours
and delete any files older than 1 week. An initial jitter
intends to avoid contention on the filesystem where multiple
registries with the same storage driver are started
simultaneously.
2015-04-16 10:57:34 -07:00
Stephen Day
c5f416119f
Merge pull request #361 from moxiegirl/docs-part-two
...
docs: updating with new RC work
2015-04-16 10:55:47 -07:00
Mary Anthony
b939d6d118
Updating with new RC work
...
Fixing typos and adding tables
Updating with testing material
Tweak after read through
Adding in Stephen's comments
Adding in Richard's comments. Fixing the broken images
closes issue #363
Another try
Signed-off-by: Mary Anthony <mary@docker.com>
2015-04-16 10:44:30 -07:00
Stephen Day
e57319cc60
Merge pull request #371 from docker/dmp42-patch-1
...
Update README.md
2015-04-16 10:38:19 -07:00
Jessie Frazelle
399b11cf29
Merge pull request #367 from bfirsh/update-landing-page
...
docs: add landing page for Registry to docs
2015-04-16 10:15:54 -07:00
Ben Firshman
ec9b9d560f
Add landing page for Registry to docs
...
- Explain why you would want to use a registry
- Explain difference between Docker Hub and Registry
- List some features of Registry
- Add table of contents for documentation - particularly "deploying a registry" call to action
- Use standard "Getting help" section from orchestration projects
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
2015-04-16 10:01:36 -07:00
Olivier Gambier
e7c91169e8
Update README.md
...
Fix version requirement.
2015-04-16 02:57:02 -07:00
Stephen Day
c5183a446b
Merge pull request #369 from stevvooe/http-request-status-context-manager
...
context, registry/handlers: instantiate http context before dispatch
2015-04-15 23:23:40 -07:00
Stephen Day
75983a4a7f
Merge pull request #364 from ncdc/resumable-digest-optional
...
Use a build flag to disable resumable digests
2015-04-15 23:22:25 -07:00
Stephen Day
2380699cf8
Merge pull request #366 from stevvooe/log-version
...
cmd/registry: correctly log application version
2015-04-15 23:21:38 -07:00
Stephen J Day
7420a3de10
Instantiate http context before dispatch
...
Ensure that the status is logged in the context by instantiating before the
request is routed to handlers. While this requires some level of hacking to
acheive, the result is that the context value of "http.request.status" is as
accurate as possible for each request.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-15 19:53:36 -07:00